From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43293 invoked by alias); 13 Feb 2018 12:33:59 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 43277 invoked by uid 89); 13 Feb 2018 12:33:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 12:33:57 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2EA02213F8 for ; Tue, 13 Feb 2018 07:33:55 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 13 Feb 2018 07:33:55 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-179-112-159.range86-179.btcentralplus.com [86.179.112.159]) by mail.messagingengine.com (Postfix) with ESMTPA id C4692246AC for ; Tue, 13 Feb 2018 07:33:54 -0500 (EST) Subject: Re: [PATCH cygport] Produce obsoletes: headers in .hint files To: cygwin-apps@cygwin.com References: <20180206211309.455912-1-jon.turney@dronecode.org.uk> From: Jon Turney Message-ID: <7d104508-783a-8ff3-8a4c-8763bd8e1b88@dronecode.org.uk> Date: Tue, 13 Feb 2018 12:33:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00024.txt.bz2 On 13/02/2018 06:30, Yaakov Selkowitz wrote: > On 2018-02-06 15:13, Jon Turney wrote: >> lib/pkg_pkg.cygpart | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart >> index 0dba03d..aa6f0e8 100644 >> --- a/lib/pkg_pkg.cygpart >> +++ b/lib/pkg_pkg.cygpart >> @@ -718,6 +718,11 @@ requires: ${pkg_bin_requires} ${!pkg_requires_var} >> sdesc: "${!pkg_summary_var:-${SUMMARY}}" >> ldesc: "${!pkg_description_var:-${DESCRIPTION:-${!pkg_summary_var:-${SUMMARY}}}}" >> _EOF >> + if [ -n "${!pkg_obsoletes_var}" ] >> + then >> + cat >> ${distdir}/${PN}/${distsubdir}/${pkg_name[${n}]}-${PVR}.hint <<-_EOF >> +obsoletes: ${!pkg_obsoletes_var} > > This is missing the closing _EOF in both hunks. (The testsuite did its > job though, and failed pretty badly.) Pushed, with that change. Thanks. It seems I added the _EOF locally and forgot to check it in :(