From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3201 invoked by alias); 25 Nov 2017 16:49:38 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 3188 invoked by uid 89); 25 Nov 2017 16:49:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Brian, inglis, Inglis, urls X-HELO: limerock01.mail.cornell.edu Received: from limerock01.mail.cornell.edu (HELO limerock01.mail.cornell.edu) (128.84.13.241) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Nov 2017 16:49:36 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vAPGnXLc031630 for ; Sat, 25 Nov 2017 11:49:34 -0500 Received: from [192.168.1.148] (c-73-69-84-56.hsd1.ct.comcast.net [73.69.84.56]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vAPGnWlt012547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sat, 25 Nov 2017 11:49:33 -0500 Subject: Re: [PATCH] make setup mirror list more like web page not just urls To: cygwin-apps@cygwin.com References: <09c0dc5b-f975-42a9-a204-b02edef6a3ad@SystematicSw.ab.ca> <53a8001e-10ae-6318-ba3d-31d0cfa18f14@SystematicSw.ab.ca> <88f044cc-2f14-94ef-1110-7b3853a088ee@SystematicSw.ab.ca> <2c7d6401-e6c9-f2d3-8d20-a15a943e058d@cornell.edu> <12d6e1a6-1eec-dc22-786b-3bcb91a4818e@cornell.edu> <0c71ec4f-3bd2-cf17-749f-be77556c4cc1@SystematicSw.ab.ca> From: Ken Brown Message-ID: <8118036b-fa91-1f0b-7d36-bb9351b77530@cornell.edu> Date: Sat, 25 Nov 2017 16:49:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <0c71ec4f-3bd2-cf17-749f-be77556c4cc1@SystematicSw.ab.ca> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00110.txt.bz2 On 11/24/2017 4:47 PM, Brian Inglis wrote: > I am suggesting we split get_site_list to create the setup.rc cached list at the > start, flag entries false, So you're throwing away the information that the entries in the cached site list came from mirrors.lst in a previous setup run? > merge the last-mirror entry into that, The sites listed under "last-mirror" are those that were selected during the last setup run. They can include user-added URLs as well as mirrors from mirrors.lst. They shouldn't be merged into the cached site list. > checking the > url for a match to use the list entry instead of the last mirror entry, then > after the mirrors.lst download, compare the cached entries with the mirrors list > entries, checking the url for a match to use the current mirrors list entry > instead of the cached entry, I'm not sure what you mean here. Are you proposing merging the cached site list into all_site_list along with the sites from the current mirrors.lst? I don't think that's a good idea. It would mean deliberately showing the user old mirrors that are no longer in mirrors.lst. Currently that only happens if such a mirror came from the "last-mirror" list, and it generates a warning when it happens. > which would be flagged true in the cached list, and > proceeding with the rest of get_site_list and then check_dropped_mirrors. > > (Also noticed, the site list search and merge operations in registerSavedSite > and load_site_list could be refactored into a separate site_list::merge() member > function, by allowing for an optional exclusion site list.) Ken