From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-042.btinternet.com (mailomta22-sa.btinternet.com [213.120.69.28]) by sourceware.org (Postfix) with ESMTPS id B8B033858289 for ; Mon, 27 Mar 2023 18:43:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8B033858289 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.38.6]) by sa-prd-fep-042.btinternet.com with ESMTP id <20230327184351.KQKL16997.sa-prd-fep-042.btinternet.com@sa-prd-rgout-003.btmx-prd.synchronoss.net>; Mon, 27 Mar 2023 19:43:51 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 64067FEB0266C8CD X-Originating-IP: [81.153.98.181] X-OWM-Source-IP: 81.153.98.181 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddguddvlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedvtdetffekveevjeegheeglefhtdeggfeilefggfdutedufedvgefgieeiffdtveenucfkphepkedurdduheefrdelkedrudekudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrudekuddpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgvvhfkrfephhhoshhtkeduqdduheefqdelkedqudekuddrrhgrnhhgvgekuddqudehfedrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepshgr qdhprhguqdhrghhouhhtqddttdef X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.181) by sa-prd-rgout-003.btmx-prd.synchronoss.net (5.8.814) (authenticated as jonturney@btinternet.com) id 64067FEB0266C8CD; Mon, 27 Mar 2023 19:43:51 +0100 Message-ID: <822a414c-be34-319e-c8d9-810cf7383e7e@dronecode.org.uk> Date: Mon, 27 Mar 2023 19:43:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip To: "cygwin-apps@cygwin.com" , Achim Gratz References: Content-Language: en-GB From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1189.7 required=5.0 tests=BAYES_00,BODY_8BITS,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: >> -        usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o) >> +        usr/lib/gcc/*/*.o) > > Why this change? > >> +    local nproc=$(nproc) > > This limit should probably be taken from the --jobs command line > parameter, if specified Looking at this a bit more, a couple of perhaps more serious problems: * The parallel invocations of __prepstrip_one are all appending to ${T}/.dbgsrc.out I don't see what makes that safe against interleaving of the output. It's probably possible to have each instance write to a separate file and collect them together in __prepdebugsrc * This patch causes several failures in the testsuite, e.g. with autotools/c testcase. On a brief attempt at debugging, it this looks like it's due to not waiting for all the __prepstrip_one to complete before moving on, but I think the final wait should prevent that, so idk. I'm not clear that invoking 'jobs', is actually doing anything, if job-control is turned off in a non-interactive shell?