From: Christian Franke <Christian.Franke@t-online.de>
To: Jon Turney <jon.turney@dronecode.org.uk>,
Achim Gratz <Stromeko-i47jiTeKxPI@public.gmane.org>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [Bug] setup regression
Date: Mon, 26 Sep 2022 17:14:15 +0200 [thread overview]
Message-ID: <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> (raw)
In-Reply-To: <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]
Jon Turney wrote:
> On 22/09/2022 17:56, Achim Gratz wrote:
>> Achim Gratz writes:
>>> Achim Gratz writes:
>>>> I had updated setup to 2.921 recently, so I rolled it back to 2.920
>>>> and
>>>> this version does the package selection correctly. I haven't yet
>>>> looked
>>>> what commit is responsible, but whatever the cause of the
>>>> regression is
>>>> still in 2.922 as well.
>>>
>>> The most likely change responsible for this is the additions in
>>> package_meta.cc in commit c99e4c14911181636892355a4f1855024051ea1d. I
>>> might not be able to check this tomorrow, though I'll try to free up
>>> some time for that.
>>
>> That was indeed the culprit. I've reverted just these two hunks on top
>> of release_2.922 and things worked again.
>>
>
> Yes, looking again at that change, the first hunk in package_meta.cc,
> changing Install_action doesn't look right.
Indeed and this should be removed ASAP - patch attached.
Thanks for catching and sorry for the regression.
>
> If I remember correctly action=Install_action, desired=empty package
> version (evaluating as a boolean is false) means "install the solver's
> preferred version", so converting that to NoChange_action seems wrong.
>
> I'm kind of confused how to reproduce this, or why it decided to
> install only some things, rather than nothing.
>
> Christian,
>
> From your reply to
> https://cygwin.com/pipermail/cygwin-apps/2022-August/042212.html, it
> seems this change is meant to handle the case where 'I' is pressed but
> the package isn't accessible? Although I don't seem quite how.
I made the false assumption that default_version=empty in set_action()
always implies that the default version is not accessible. This is not
the case for packages selected for installation before chooser is visible.
I'm working on a new fix for the "Ctrl+I pressed but current version is
not accessible" case. The correct logic is already in toggle_action():
Install the most recent accessible non-test ('naively_preferred') version.
[-- Attachment #2: 0001-Fix-ignored-install-requests-added-before-run-of-sol.patch --]
[-- Type: text/plain, Size: 788 bytes --]
From 54665f0596f8ca50eff99ec8ec35970dc5fd439d Mon Sep 17 00:00:00 2001
From: Christian Franke <christian.franke@t-online.de>
Date: Mon, 26 Sep 2022 16:47:42 +0200
Subject: [PATCH] Fix ignored install requests added before run of solver
Regression was introduced by commit c99e4c1.
---
package_meta.cc | 7 -------
1 file changed, 7 deletions(-)
diff --git a/package_meta.cc b/package_meta.cc
index a5dc436..05b8946 100644
--- a/package_meta.cc
+++ b/package_meta.cc
@@ -651,13 +651,6 @@ packagemeta::set_action (_actions action, packageversion const &default_version,
srcpick (false);
}
}
- else
- {
- action = NoChange_action;
- desired = installed;
- pick (false);
- srcpick (false);
- }
}
else if (action == Reinstall_action)
{
--
2.37.2
next prev parent reply other threads:[~2022-09-26 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 17:38 Achim Gratz
2022-09-21 18:00 ` Achim Gratz
2022-09-22 16:56 ` Achim Gratz
2022-09-23 14:45 ` Jon Turney
2022-09-26 15:14 ` Christian Franke [this message]
2022-09-27 13:51 ` Christian Franke
2022-10-01 15:28 ` Jon Turney
2022-10-03 19:15 ` Achim Gratz
2022-10-05 18:40 ` Achim Gratz
2022-10-04 11:50 ` Christian Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de \
--to=christian.franke@t-online.de \
--cc=Stromeko-i47jiTeKxPI@public.gmane.org \
--cc=cygwin-apps@cygwin.com \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).