From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout08.t-online.de (mailout08.t-online.de [194.25.134.20]) by sourceware.org (Postfix) with ESMTPS id 48B143858D37 for ; Mon, 26 Sep 2022 15:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48B143858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd88.dcpf.telekom.de (fwd88.aul.t-online.de [10.223.144.114]) by mailout08.t-online.de (Postfix) with SMTP id C026CD53A; Mon, 26 Sep 2022 17:14:15 +0200 (CEST) Received: from [192.168.2.101] ([79.230.173.42]) by fwd88.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1ocpoF-07Zwa80; Mon, 26 Sep 2022 17:14:15 +0200 Subject: Re: [Bug] setup regression To: Jon Turney , Achim Gratz , "cygwin-apps@cygwin.com" References: <87leqcocft.fsf@Rainer.invalid> <87h710obeh.fsf@Rainer.invalid> <87tu4z5owu.fsf@Rainer.invalid> <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> From: Christian Franke Message-ID: <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> Date: Mon, 26 Sep 2022 17:14:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------DE01AC909CD040A14FF8B8F4" X-TOI-EXPURGATEID: 150726::1664205255-E30B0E65-F6352EF8/0/0 CLEAN NORMAL X-TOI-MSGID: d79cd8a5-90dd-436a-a70e-3a755f5b5afa X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------DE01AC909CD040A14FF8B8F4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Jon Turney wrote: > On 22/09/2022 17:56, Achim Gratz wrote: >> Achim Gratz writes: >>> Achim Gratz writes: >>>> I had updated setup to 2.921 recently, so I rolled it back to 2.920 >>>> and >>>> this version does the package selection correctly.  I haven't yet >>>> looked >>>> what commit is responsible, but whatever the cause of the >>>> regression is >>>> still in 2.922 as well. >>> >>> The most likely change responsible for this is the additions in >>> package_meta.cc in commit c99e4c14911181636892355a4f1855024051ea1d.  I >>> might not be able to check this tomorrow, though I'll try to free up >>> some time for that. >> >> That was indeed the culprit.  I've reverted just these two hunks on top >> of release_2.922 and things worked again. >> > > Yes, looking again at that change, the first hunk in package_meta.cc, > changing Install_action doesn't look right. Indeed and this should be removed ASAP - patch attached. Thanks for catching and sorry for the regression. > > If I remember correctly action=Install_action, desired=empty package > version (evaluating as a boolean is false) means "install the solver's > preferred version", so converting that to NoChange_action seems wrong. > > I'm kind of confused how to reproduce this, or why it decided to > install only some things, rather than nothing. > > Christian, > > From your reply to > https://cygwin.com/pipermail/cygwin-apps/2022-August/042212.html, it > seems this change is meant to handle the case where 'I' is pressed but > the package isn't accessible?  Although I don't seem quite how. I made the false assumption that default_version=empty in set_action() always implies that the default version is not accessible. This is not the case for packages selected for installation before chooser is visible. I'm working on a new fix for the "Ctrl+I pressed but current version is not accessible" case. The correct logic is already in toggle_action(): Install the most recent accessible non-test ('naively_preferred') version. --------------DE01AC909CD040A14FF8B8F4 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-ignored-install-requests-added-before-run-of-sol.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-ignored-install-requests-added-before-run-of-sol.pa"; filename*1="tch" RnJvbSA1NDY2NWYwNTk2ZjhjYTUwZWZmOTllYzhlYzM1OTcwZGM1ZmQ0MzlkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBNb24sIDI2IFNlcCAyMDIyIDE2OjQ3OjQyICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gRml4IGlnbm9yZWQgaW5zdGFsbCByZXF1ZXN0cyBhZGRlZCBi ZWZvcmUgcnVuIG9mIHNvbHZlcgoKUmVncmVzc2lvbiB3YXMgaW50cm9kdWNlZCBieSBjb21t aXQgYzk5ZTRjMS4KLS0tCiBwYWNrYWdlX21ldGEuY2MgfCA3IC0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3BhY2thZ2VfbWV0YS5jYyBi L3BhY2thZ2VfbWV0YS5jYwppbmRleCBhNWRjNDM2Li4wNWI4OTQ2IDEwMDY0NAotLS0gYS9w YWNrYWdlX21ldGEuY2MKKysrIGIvcGFja2FnZV9tZXRhLmNjCkBAIC02NTEsMTMgKzY1MSw2 IEBAIHBhY2thZ2VtZXRhOjpzZXRfYWN0aW9uIChfYWN0aW9ucyBhY3Rpb24sIHBhY2thZ2V2 ZXJzaW9uIGNvbnN0ICZkZWZhdWx0X3ZlcnNpb24sCiAJICAgICAgc3JjcGljayAoZmFsc2Up OwogCSAgICB9CiAJfQotICAgICAgZWxzZQotCXsKLQkgIGFjdGlvbiA9IE5vQ2hhbmdlX2Fj dGlvbjsKLQkgIGRlc2lyZWQgPSBpbnN0YWxsZWQ7Ci0JICBwaWNrIChmYWxzZSk7Ci0JICBz cmNwaWNrIChmYWxzZSk7Ci0JfQogICAgIH0KICAgZWxzZSBpZiAoYWN0aW9uID09IFJlaW5z dGFsbF9hY3Rpb24pCiAgICAgewotLSAKMi4zNy4yCgo= --------------DE01AC909CD040A14FF8B8F4--