public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: per-version hints proposal
Date: Wed, 12 Apr 2017 20:51:00 -0000	[thread overview]
Message-ID: <84e63aa0-de56-94c8-0d89-67574acae97b@cornell.edu> (raw)
In-Reply-To: <87lgraal6n.fsf@Rainer.invalid>

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On 4/8/2017 1:00 PM, Achim Gratz wrote:
> Jon Turney writes:
>> cygport will be updated to (details TBC) accept a --test flag which is
>> significant to the cygport package stage, and adds this 'test:' line
>> to all the generated PVR.hint files.
>
> I've opted to make it a command (package-test or pkg-test) instead, as
> that seems to fall more in line with my usage pattern and types easier.

What about just using a variable (say PKG_TEST) in the cygport file. 
For example, the line

   PKG_TEST=1

would cause the 'test:' line to be added to the hint files.

The attached patch implements this.

Ken


[-- Attachment #2: 0001-pkg_pkg-implement-PKG_TEST.patch --]
[-- Type: text/plain, Size: 702 bytes --]

From a9a63675dd83416a4ec510c3a2e2c2ca9eda9ad4 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Wed, 12 Apr 2017 15:39:26 -0400
Subject: [PATCH] pkg_pkg: implement PKG_TEST

---
 lib/pkg_pkg.cygpart | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart
index 5552040..69910fc 100644
--- a/lib/pkg_pkg.cygpart
+++ b/lib/pkg_pkg.cygpart
@@ -717,6 +717,12 @@ _EOF
 message: ${pkg_name[${n}]} "${!pkg_message_var}"
 _EOF
 			fi
+			if defined PKG_TEST
+			then
+				cat >> ${distdir}/${PN}/${distsubdir}/${pkg_name[${n}]}-${PVR}.hint <<-_EOF
+test:
+_EOF
+			fi
 		else
 			warning "${pkg_hint[${n}]%.hint}.hint is missing";
 		fi
-- 
2.8.3


  reply	other threads:[~2017-04-12 20:51 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 15:28 Jon Turney
2016-06-21 12:03 ` Corinna Vinschen
2016-06-21 13:49   ` Marco Atzeri
2016-06-21 14:28     ` Corinna Vinschen
2016-06-21 15:32       ` Marco Atzeri
2016-06-21 14:09   ` Eric Blake
2016-06-21 14:27     ` Corinna Vinschen
2016-06-21 18:04     ` Achim Gratz
2016-06-21 18:27   ` Jon Turney
2016-08-30 12:24 ` Jon Turney
2016-08-31 19:14   ` Achim Gratz
2016-09-01 17:15     ` Jon Turney
2016-12-08 19:30   ` Jon Turney
2016-12-09 10:46     ` Corinna Vinschen
2016-12-09 11:10       ` Corinna Vinschen
2016-12-12 13:29         ` Jon Turney
2016-12-12 13:29       ` Jon Turney
2017-04-08 17:00     ` Achim Gratz
2017-04-12 20:51       ` Ken Brown [this message]
2017-04-13  6:24         ` Achim Gratz
2016-09-17  6:15 ` Achim Gratz
2016-09-18  5:17   ` Marco Atzeri
2016-09-18 15:14     ` Jon Turney
2016-09-18 16:12       ` Achim Gratz
2016-09-18 16:29         ` Achim Gratz
2016-09-19 15:37           ` Ken Brown
2016-09-19 18:24             ` Achim Gratz
2016-09-19 22:23               ` Jon Turney
2016-09-18 16:40       ` Ken Brown
2016-09-18 16:53         ` Marco Atzeri
2016-09-18 17:16           ` Achim Gratz
2016-09-18 18:08             ` Marco Atzeri
2016-09-22 13:44 ` Eric Blake
2016-12-10 22:42 ` How to override previous version? David Rothenberger
2016-12-11  0:03   ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84e63aa0-de56-94c8-0d89-67574acae97b@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).