public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>,
	Christian Franke <Christian.Franke@t-online.de>,
	Achim Gratz <Stromeko@nexgo.de>
Subject: Re: [Bug] setup regression
Date: Sat, 1 Oct 2022 16:28:55 +0100	[thread overview]
Message-ID: <861e906d-0eef-abc8-2518-f1d32276bcd7@dronecode.org.uk> (raw)
In-Reply-To: <4d751290-09dd-b9c5-fcd1-aaf09b1aba89@t-online.de>

On 27/09/2022 14:51, Christian Franke wrote:
> Christian Franke wrote:
>> ...
>> I made the false assumption that default_version=empty in set_action() 
>> always implies that the default version is not accessible. This is not 
>> the case for packages selected for installation before chooser is 
>> visible.
>>
>> I'm working on a new fix for the "Ctrl+I pressed but current version 
>> is not accessible" case. ...
> 
> See attached patch. It also fixes the same problem for the "Category" 
> view. Testing shows that the problem only affects the display of the 
> version number as the solver later silently removes such install requests.
> 
> 
>> The correct logic is already in toggle_action(): Install the most 
>> recent accessible non-test ('naively_preferred') version.
>>
> 
> I dropped this idea and aligned Ctrl+I behavior with "Install" from 
> "Category" view instead. Toggle_action() behaves different in such 
> corner cases as it always installs something.

Thanks, I applied both patches.

Do you have a simple way of causing a non-accessible package for testing 
with?

Achim,

Can you confirm if this fixes package selection for you?


  reply	other threads:[~2022-10-01 15:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 17:38 Achim Gratz
2022-09-21 18:00 ` Achim Gratz
2022-09-22 16:56   ` Achim Gratz
2022-09-23 14:45     ` Jon Turney
2022-09-26 15:14       ` Christian Franke
2022-09-27 13:51         ` Christian Franke
2022-10-01 15:28           ` Jon Turney [this message]
2022-10-03 19:15             ` Achim Gratz
2022-10-05 18:40               ` Achim Gratz
2022-10-04 11:50             ` Christian Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861e906d-0eef-abc8-2518-f1d32276bcd7@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=Christian.Franke@t-online.de \
    --cc=Stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).