From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-046.btinternet.com (mailomta21-sa.btinternet.com [213.120.69.27]) by sourceware.org (Postfix) with ESMTPS id 99A2D3858D38 for ; Sat, 1 Oct 2022 15:28:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99A2D3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-046.btinternet.com with ESMTP id <20221001152856.CKQC3113.sa-prd-fep-046.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Sat, 1 Oct 2022 16:28:56 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139417C3CFC0036 X-Originating-IP: [81.153.98.187] X-OWM-Source-IP: 81.153.98.187 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehhedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeffkeeigfdujeehteduiefgjeeltdelgeelteekudetfedtffefhfeufefgueettdenucfkphepkedurdduheefrdelkedrudekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrudekjedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepvehhrhhishhtihgrnhdrhfhrrghnkhgvsehtqdhonhhlihhnvgdruggvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.187) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139417C3CFC0036; Sat, 1 Oct 2022 16:28:56 +0100 Message-ID: <861e906d-0eef-abc8-2518-f1d32276bcd7@dronecode.org.uk> Date: Sat, 1 Oct 2022 16:28:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [Bug] setup regression To: "cygwin-apps@cygwin.com" , Christian Franke , Achim Gratz References: <87leqcocft.fsf@Rainer.invalid> <87h710obeh.fsf@Rainer.invalid> <87tu4z5owu.fsf@Rainer.invalid> <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> <4d751290-09dd-b9c5-fcd1-aaf09b1aba89@t-online.de> Content-Language: en-GB From: Jon Turney In-Reply-To: <4d751290-09dd-b9c5-fcd1-aaf09b1aba89@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3570.1 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/09/2022 14:51, Christian Franke wrote: > Christian Franke wrote: >> ... >> I made the false assumption that default_version=empty in set_action() >> always implies that the default version is not accessible. This is not >> the case for packages selected for installation before chooser is >> visible. >> >> I'm working on a new fix for the "Ctrl+I pressed but current version >> is not accessible" case. ... > > See attached patch. It also fixes the same problem for the "Category" > view. Testing shows that the problem only affects the display of the > version number as the solver later silently removes such install requests. > > >> The correct logic is already in toggle_action(): Install the most >> recent accessible non-test ('naively_preferred') version. >> > > I dropped this idea and aligned Ctrl+I behavior with "Install" from > "Category" view instead. Toggle_action() behaves different in such > corner cases as it always installs something. Thanks, I applied both patches. Do you have a simple way of causing a non-accessible package for testing with? Achim, Can you confirm if this fixes package selection for you?