From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpout2.vodafonemail.de (smtpout2.vodafonemail.de [145.253.239.133]) by sourceware.org (Postfix) with ESMTPS id F0F62385782B for ; Tue, 18 May 2021 04:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F0F62385782B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Stromeko@nexgo.de Received: from smtp.vodafone.de (smtpa06.fra-mediabeam.com [10.2.0.37]) by smtpout2.vodafonemail.de (Postfix) with ESMTP id D9EED12220F for ; Tue, 18 May 2021 06:36:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexgo.de; s=vfde-smtpout-mb-15sep; t=1621312613; bh=n/m8F06NSzTmNckLnhLIomTq1jamb2GBjLCe1keWs+M=; h=From:To:Subject:References:Date:In-Reply-To; b=Wgi12Z9kgF40ytfpoa0VJNOQQI0+V8+KT8AvvU1v1HaJpAXz4elNuU1wbqMvnt6uI gtdayuKyNhf/nEsPZMeGOBvfdokLdaoBir7S82Bc39/GedKZAw7PsDrpdNsPgL5LZ8 sIEA2xvXhqWVWA8ILBRp55v/KDgbnxXmPoi9l3Qg= Received: from Otto (p54a0c8c7.dip0.t-ipconnect.de [84.160.200.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 7150C140172 for ; Tue, 18 May 2021 04:36:53 +0000 (UTC) From: ASSI To: cygwin-apps@cygwin.com Subject: Re: cygport test has zero exit status on failures References: <01ad01d74517$f9f4e6e0$eddeb4a0$@pdinc.us> <87h7jbuqir.fsf@Otto.invalid> <009c01d74b6c$1ce8f7e0$56bae7a0$@pdinc.us> Date: Tue, 18 May 2021 06:36:49 +0200 In-Reply-To: <009c01d74b6c$1ce8f7e0$56bae7a0$@pdinc.us> (Jason Pyeron's message of "Mon, 17 May 2021 18:29:34 -0400") Message-ID: <8735ukejz2.fsf@Otto.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1149 X-purgate-ID: 155817::1621312613-00000684-7A7C37E3/0/0 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 04:36:59 -0000 Jason Pyeron writes: > What is the historic rationale behind the "OR true" after the make > check? Not historic for the most part, I'd say. Cygport can also do cross-builds of packages and in those cases the tests will seldomly work (at all or at least partly) unless upstream walked the extra mile. Also, due to ATWIL syndrome and other factors, Cygwin is often not explicitly considered a target platform or (even then) treated wrongly in different ways, so even when building natively you will encounter your fair share of spurious test fails. > It seems silly to have to redefine src_test() as { > cd ${B} > make check > }, just to have a failure exit code if the test fail. It would be equally silly the other way around in a different set of circumstances. But yes, making this configurable might be useful, but this should then be done in the local configuration, not in the cygport file. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf rackAttack: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds