public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: [ATTN MAINTAINER] openssh
Date: Mon, 29 Nov 2021 18:34:12 +0100	[thread overview]
Message-ID: <874k7uvpbf.fsf@Rainer.invalid> (raw)
In-Reply-To: <YaTCdDeoN6SNgOih@calimero.vinschen.de> (Corinna Vinschen via Cygwin-apps's message of "Mon, 29 Nov 2021 13:07:16 +0100")

Corinna Vinschen via Cygwin-apps writes:
> On Nov 28 10:53, Achim Gratz wrote:
>> Achim Gratz writes:
>> > These patches work for 32bit also and I believe they are correct, but
>> > that build should not be made available due to a bug in libfido2 that
>> > crashes when trying to free the memory associated with the WebAuthn
>> > payload returned.  Without these patches applied you can still use the
>> > fallback to USB-HID when you are an administrator.
>> 
>> The call into WebAuthn completely messes up the stack apparently.  The
>> returned object looks OK once you realize it is a version 1 and thus the
>> extension fields are bogus, but the whole thing crashes if you do just
>> one more call.  Gdb session:
>> 
>> https://paste.c-net.org/SerumLoser
>> 
>> Any ideas what that might be?
>
> For the bystanders, on a hunch I created a libfido2 patch to change
> the calling convention for the dynamically loaded windows functions.
> Let's see if Achim's testing now succeeds on 32 bit...

It does, your hunches are _that_ good.  :-)

So, once the new libfido2 hits the release area you can pull in the
OpenSSH patches and re-release that to take advantage of the now
correctly working Webauthn suppport.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

      reply	other threads:[~2021-11-29 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 10:01 Achim Gratz
2021-11-28  9:53 ` Achim Gratz
2021-11-29 12:07   ` Corinna Vinschen
2021-11-29 17:34     ` Achim Gratz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k7uvpbf.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).