From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vsmx009.vodafonemail.xion.oxcs.net (vsmx009.vodafonemail.xion.oxcs.net [153.92.174.87]) by sourceware.org (Postfix) with ESMTPS id A2328385DC34 for ; Tue, 7 Apr 2020 18:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2328385DC34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Stromeko@nexgo.de Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id AE4BE159E1D0 for ; Tue, 7 Apr 2020 18:11:21 +0000 (UTC) Received: from Gertrud (unknown [84.160.196.178]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 76C25159E1D7 for ; Tue, 7 Apr 2020 18:11:19 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: cygport patches for consideration References: <87k12tbw5u.fsf@Rainer.invalid> <878sj7ck7e.fsf@Rainer.invalid> <11ecc96f072ada00b135d5a1c3de0c5987f069dc.camel@cygwin.com> Date: Tue, 07 Apr 2020 20:11:18 +0200 In-Reply-To: <11ecc96f072ada00b135d5a1c3de0c5987f069dc.camel@cygwin.com> (Yaakov Selkowitz's message of "Tue, 07 Apr 2020 13:37:13 -0400") Message-ID: <874ktvcgjd.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-VADE-STATUS: LEGIT X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 18:11:25 -0000 Yaakov Selkowitz writes: >> I guess I can change my cygport generator instead to use >> CPAN_DIR when needed, but haven't got around doing so. > > Depending on its size, it would be nice to get this generator into > cygport's tools, and could possibly be used as the basis for other such > generators for other languages. It does a few other things before it gets to generating a cygport file. It'd probably be a day or two of excising the cygport generation facility, but again I'd need a round tuit. But then again who knows what we might have time for unexpectedly=E2=80=A6 > This change would reduce the number of possible dependencies found by > only looking for those starting at the beginning of a line, which > should eliminate false positives from perldocs and optional deps. So, > yes, some more false negatives, but also much less false positives.=20 > When would there be false positives in this case? I haven't tested it, but it seems that you would pick up conditional imports that employ the "if" pragmatic module (which is the canonical way of doing conditional imports). Short of special-casing the more common uses of these you're left holding the bag on these anyway since you simply can't know whether the condition is true without evaluating the scope. On the other hand you're now prone to skip imports in BEGIN blocks, since these would mostly be indented. >> When looking in setup.log.full=E2=80=A6 this output used to go to the c= onsole, >> but got axed quite some time ago. > > Most people aren't going to check the log for that, nor does the log > allow them to do anything about it. Well, at least it lets them know _if_ they care. >> > What would make more sense is to have a utility akin to "rpmconf -a" >> > on RPM-based systems which allows the user to compare existing files >> > with their /etc/defaults and choose if and how to merge the >> > differences. >>=20 >> Sure, but that's not cygport's business, no? > > No, this would be something separate, or possibly part of cygutils.=20 > But's it's not the postinstall's business either AFAIAC. That's the only good place we have at the moment. I've built it into base-files three and a half years ago in case you're wondering. Regards, Achim. --=20 +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada