From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26854 invoked by alias); 24 Jul 2013 20:45:25 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 26842 invoked by uid 89); 24 Jul 2013 20:45:24 -0000 X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mail-in-13.arcor-online.net) (151.189.21.53) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Jul 2013 20:45:23 +0000 Received: from mail-in-05-z2.arcor-online.net (mail-in-05-z2.arcor-online.net [151.189.8.17]) by mx.arcor.de (Postfix) with ESMTP id 8B85B2122D8 for ; Wed, 24 Jul 2013 22:45:14 +0200 (CEST) Received: from mail-in-01.arcor-online.net (mail-in-01.arcor-online.net [151.189.21.41]) by mail-in-05-z2.arcor-online.net (Postfix) with ESMTP id 85F5C6F3A65 for ; Wed, 24 Jul 2013 22:45:14 +0200 (CEST) Received: from Rainer.invalid (pD9EB0A73.dip0.t-ipconnect.de [217.235.10.115]) (Authenticated sender: stromeko@arcor.de) by mail-in-01.arcor-online.net (Postfix) with ESMTPSA id 4FCB710 for ; Wed, 24 Jul 2013 22:45:14 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-01.arcor-online.net 4FCB710 Message-Id: <874nbjbsbw.fsf@Rainer.invalid> Resent-To: cygwin-apps@cygwin.com Resent-From: Achim Gratz Resent-Date: Wed, 24 Jul 2013 22:45:06 +0200 Resent-Message-ID: <877ggfbsbx.fsf@Rainer.invalid> References: <87a9lexyk8.fsf@Rainer.invalid> <20130724115129.GT9689@calimero.vinschen.de> To: cygwin-apps@cygwin.com Subject: Re: [PATCH 0/4 setup] package re-/de-installation from CLI From: Achim Gratz Date: Wed, 24 Jul 2013 20:45:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00293.txt.bz2 Corinna Vinschen writes: > I think that would make sense. I'm, not too sure what exactly you're > doing in this patch. I hope it is a bit more clear now, otherwise just ask (or consult the thread from February). > It looks a bit intrusive for adding two options. Four, actually. I've split out the last two again into the last patch of the series since Chris only really said he wanted the first two. The rest of the apparent intrusiveness really comes about because the function that does the work has been re-implemented to use a higher-level interface to the package DB. There were lots of corner cases and latent bugs with using the low-level interfaces that would have needed cleanup otherwise. > Also, your ChangeLog is incorrectly formatted. Have a look into the > existing ChangeLog, please. I hope I matched it better this time. > Can you please attach the patches to your mail then? See the follow-ups. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables