From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mr5.vodafonemail.de (mr5.vodafonemail.de [145.253.228.165]) by sourceware.org (Postfix) with ESMTPS id 0BE723858431 for ; Sun, 2 Apr 2023 19:29:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BE723858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nexgo.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexgo.de; s=vfde-smtpout-mb-15sep; t=1680463752; bh=IVf5Itp7Q1IJeCzEt/hW/gzjX37Zb9YaGAUA5ewTyU4=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=ayR1t8AmkJW6xytCwwdW7CxdTmxFZiE5EwDn3yhWf5IXshMnC1LYfRAWTKCSGiCXK HhEhEh804rHjbVDC1J+4huGfC5mVHpvA58fG0TQV5p+rB2yx3v69YuKek5ap67EETi +lIBvbfPclQmzALBWmldsabRzkUfams9BWd+w67M= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4PqPGc5G3Jz27cP for ; Sun, 2 Apr 2023 19:29:12 +0000 (UTC) Received: from Gertrud (p57b9d9db.dip0.t-ipconnect.de [87.185.217.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4PqPGX31T0z9sL7 for ; Sun, 2 Apr 2023 19:29:05 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip References: <822a414c-be34-319e-c8d9-810cf7383e7e@dronecode.org.uk> <878rfec94o.fsf@Rainer.invalid> <197d05e2-2308-3a18-abbd-f6ced1c123aa@dronecode.org.uk> <427a2a31-26d1-7d0d-f90f-767546aac933@dronecode.org.uk> Date: Sun, 02 Apr 2023 21:28:54 +0200 In-Reply-To: <427a2a31-26d1-7d0d-f90f-767546aac933@dronecode.org.uk> (Jon Turney via Cygwin-apps's message of "Sun, 2 Apr 2023 18:39:50 +0100") Message-ID: <875yaeaxs9.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-purgate-type: clean X-purgate: clean X-purgate-size: 1791 X-purgate-ID: 155817::1680463748-F3FFE404-E48D6814/0/0 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jon Turney via Cygwin-apps writes: >> Exchange the while loop using an iffy read construct to a for loop using a temporary file. > > I think this change from zero-delimited to whitespace means this will > now fail to handle any filenames containing whitespace correctly? Yes, sorry. I thought whitespace in filenames wasn't working anyway, but at least here it was done correctly. > This commentary doesn't clearly identify what is wrong with the usage > of read here. The read itself was OK, piping the data from find into the read wasn't. I've replaced this with a process substitution and thus reinstated the whitespace protection without getting into subshell trouble. >> avoid filename collisions by using an >> SHA256 hash of the full file name. > > I think there is already a perfectly good, filesystem safe, > computationally cheap unique identifier for each filename, which is > it's ordinal number in the list of filenames we are examining. I've implemented a counter now. However I don't see the hashing of a filename as onerous when Git does that much more often and on much larger data. > 'wait -f' seems to be new in bash 5.0. I assume this fails horribly > on earlier bash versions. I'm ok with requiring that, but maybe we > should check the bash version? It should indeed be possible to drop the -f as long as job control is not enabled if I understand the manual correctly after re-reading it several times. I've done that and it looks like things still work. > On the plus side, the testsuite passes! :) Oh goody! Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada