From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55611 invoked by alias); 6 Jun 2016 17:07:39 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 55598 invoked by uid 89); 6 Jun 2016 17:07:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=wave, nexgo.de, HX-DKIM:DKIM, nexgode X-HELO: mail-in-11.arcor-online.net Received: from mail-in-11.arcor-online.net (HELO mail-in-11.arcor-online.net) (151.189.21.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 06 Jun 2016 17:07:28 +0000 Received: from mail-in-03-z2.arcor-online.net (mail-in-03-z2.arcor-online.net [151.189.8.15]) by mx.arcor.de (Postfix) with ESMTP id 3rNh2j1vckz4s75 for ; Mon, 6 Jun 2016 19:07:25 +0200 (CEST) Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) by mail-in-03-z2.arcor-online.net (Postfix) with ESMTP id 3DB1E1F6738 for ; Mon, 6 Jun 2016 19:07:25 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-13.arcor-online.net 3rNh2j0wrXz32jN Received: from Gertrud (p54B478AF.dip0.t-ipconnect.de [84.180.120.175]) (Authenticated sender: stromeko@arcor.de) by mail-in-13.arcor-online.net (Postfix) with ESMTPSA id 3rNh2j0wrXz32jN for ; Mon, 6 Jun 2016 19:07:25 +0200 (CEST) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: [ITP] libsass v3.3.6 References: <8005b674-1e74-a909-50ca-2a0b4fb0e570@gmail.com> Date: Mon, 06 Jun 2016 17:07:00 -0000 In-Reply-To: (Marcos Vives Del Sol's message of "Mon, 6 Jun 2016 18:45:39 +0200") Message-ID: <878tyiz1o6.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-06/txt/msg00009.txt.bz2 Marcos Vives Del Sol writes: >> to avoid the useless creation of libsass-3.3.6-1.src.patch > Actually the patch isn't useless. It creates a VERSION file which > version.sh expects to exist during the building process. Without that > file, the library reports version "[na]" instead of the correct 3.3.6. That file is created by configure, so patching it in anyway is still useless. In fact it's wrong the next time you update the source archive. You should never package files or patches that the build system can re-create (and by extension remove such files from the source directory should upstream package them for folks who don't use the full configury). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables