From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vsmx009.vodafonemail.xion.oxcs.net (vsmx009.vodafonemail.xion.oxcs.net [153.92.174.87]) by sourceware.org (Postfix) with ESMTPS id 7C1103857C55 for ; Fri, 7 Aug 2020 19:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C1103857C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Stromeko@nexgo.de Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 471A3159DBFB for ; Fri, 7 Aug 2020 19:09:18 +0000 (UTC) Received: from Otto (unknown [87.185.208.218]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 1A607159DAFB for ; Fri, 7 Aug 2020 19:09:16 +0000 (UTC) From: ASSI To: cygwin-apps@cygwin.com Subject: Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs. References: <20200805053448.9C87.50F79699@gmail.com> <20200807233351.4B7D.50F79699@gmail.com> Date: Fri, 07 Aug 2020 21:09:11 +0200 In-Reply-To: <20200807233351.4B7D.50F79699@gmail.com> (Lemures Lemniscati via Cygwin-apps's message of "Fri, 07 Aug 2020 23:33:53 +0900") Message-ID: <87bljm1dew.fsf@Otto.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-VADE-STATUS: LEGIT X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 19:09:24 -0000 Lemures Lemniscati via Cygwin-apps writes: >> No, I was talking about things like XZ_OPT or ZSTD_CLEVEL. > > I think XZ_OPT or ZSTD_CLEVEL can be passed through environment. > And this should control xz or zstd.. > > XZ_OPT=3D"..." cygport foo.cygport package > ZSTD_CLEVEL=3D"..." cygport foo.cygport package > > And cygport does not prevent from passing parameter through environment. > Maybe I understand you in a wrong way. Pardon me. Maybe if you'd gone back to the post I sent on June 14 when I originally offered the patch you'd have seen: >> This patch keeps the current defaults in place, but allows one to set up >> two environment variables to control how tar gets invoked during >> packaging. You could do that from either the cygport file or the >> .cygport.conf file: >> >> CYGPORT_TAR_CMD=3D"env ZSTD_CLEVEL=3D19 tar -I zstd --group nobody:65534= --owner nobody:65534" >> CYGPORT_TAR_EXT=3D".tar.zst" I don't want to pollute the environment for any other command obviously=E2= =80=A6 and really, I still think creating five new configuration variables to do what can be accomplished with two isn't a good trade-off. Factoring out the command invocation into a function probably is a net win, though -- so I'd keep that part. It'd probably be useful in some other instances to so a similar refactoring. Regards, Achim. --=20 +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables