From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx009.vodafonemail.xion.oxcs.net (mx009.vodafonemail.xion.oxcs.net [153.92.174.39]) by sourceware.org (Postfix) with ESMTPS id 2E9C03857C55 for ; Fri, 7 Aug 2020 19:42:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2E9C03857C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Stromeko@nexgo.de Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 06A756045B9 for ; Fri, 7 Aug 2020 19:42:24 +0000 (UTC) Received: from Gertrud (unknown [87.185.208.218]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id C67F46046EF for ; Fri, 7 Aug 2020 19:42:21 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: git repositories for cygwin packaging - please test References: <20e2f046-af24-14b8-b6c4-263f859042b8@dronecode.org.uk> <181ea3fa-1a50-7db4-0009-47ea9af77cdc@dronecode.org.uk> <0def9976-1575-7b03-995b-e4276bc23292@dronecode.org.uk> Date: Fri, 07 Aug 2020 21:42:17 +0200 In-Reply-To: <0def9976-1575-7b03-995b-e4276bc23292@dronecode.org.uk> (Jon Turney's message of "Thu, 6 Aug 2020 21:20:53 +0100") Message-ID: <87bljm9rae.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-VADE-STATUS: LEGIT X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 19:42:27 -0000 Jon Turney writes: > One problem I have noticed is that some packages have test suites > (which are getting run via 'cygport test' invoking src_test()) which: > > - require lots of extra dependencies to run, or I currently subsume these in BUILD_REQUIRES as they are indeed required for a (complete) build. It'd be possible to split them out into a separate variable indeed, but that is yet another level of specificatrion that needs to be figured out if it should become useful. > - don't succeed on Cygwin, or Any such tests I usually patch out or mark expected fail whichever seems easier. > - take an inordinate amount of time to run (exceeding the resource limits) That is a problem that comes with CI I think and we didn't really have had to consider so far. I have a few packages that I don't run tests on by default because the test suite produces hangs or other unstable behaviour, but that is dealt with in the src_test function itself. If there are really resource hungry tests they usually need to be enabled somewhere and one could skip those if the build runs on CIm (how to find that out?). > So I'm wondering if .cygport files need: > > - an annotation to indicate tests shouldn't be run by this system (in > RESTRICT? or somewhere new?) Not RESTRICT please, that does things related to packaging. > - a separate TEST_REQUIRES to list packages which depended on for > running tests? That seems the most prudent name in this case. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Waldorf MIDI Implementation & additional documentation: http://Synth.Stromeko.net/Downloads.html#WaldorfDocs