From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124624 invoked by alias); 2 Jul 2015 21:03:22 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 124610 invoked by uid 89); 2 Jul 2015 21:03:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-in-07.arcor-online.net Received: from mail-in-07.arcor-online.net (HELO mail-in-07.arcor-online.net) (151.189.21.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 02 Jul 2015 21:03:19 +0000 Received: from mail-in-03-z2.arcor-online.net (mail-in-03-z2.arcor-online.net [151.189.8.15]) by mx.arcor.de (Postfix) with ESMTP id 3mMsMm0XB5z87BV for ; Thu, 2 Jul 2015 23:03:16 +0200 (CEST) Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) by mail-in-03-z2.arcor-online.net (Postfix) with ESMTP id 0DDBD212308 for ; Thu, 2 Jul 2015 23:03:16 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-13.arcor-online.net 3mMsMl6jYczJM9w Received: from Gertrud (p54B46B8D.dip0.t-ipconnect.de [84.180.107.141]) (Authenticated sender: stromeko@arcor.de) by mail-in-13.arcor-online.net (Postfix) with ESMTPSA id 3mMsMl6jYczJM9w for ; Thu, 2 Jul 2015 23:03:15 +0200 (CEST) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: setup References: <20150610185417.GL31537@calimero.vinschen.de> <87wpzbs2yj.fsf@Rainer.invalid> <87mw060xg3.fsf@Rainer.invalid> <20150612102945.GS31537@calimero.vinschen.de> <87bngkzwki.fsf@Rainer.invalid> <87ioa8t0ha.fsf@Rainer.invalid> <20150629134154.GA2918@calimero.vinschen.de> <873819okox.fsf@Rainer.invalid> <20150630164052.GE2918@calimero.vinschen.de> <87vbe3ehrb.fsf@Rainer.invalid> <20150702091018.GA21212@calimero.vinschen.de> Date: Thu, 02 Jul 2015 21:03:00 -0000 In-Reply-To: <20150702091018.GA21212@calimero.vinschen.de> (Corinna Vinschen's message of "Thu, 2 Jul 2015 11:10:18 +0200") Message-ID: <87bnfu2rxs.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-07/txt/msg00003.txt.bz2 Corinna Vinschen writes: > (*) This puzzles me a bit. You're keeping arrays and lists in terms of > the file suffix (setup_ext, setup_ext_list), but you don't use the > information here and elsewhere. THat vector is a relatively late addition to the code when the rest was already using literals as before. It's something that I want to clean up, but not necessarily right now. As you noted, I'd probably need to use a more structured data type. > I'd prefer /* */ for multiline comments, but that's used pretty > inconsistently anyway, so, never mind. If you insist=E2=80=A6 but setup is C++ and not C anyway. > The existing code is inconsistently formatted, but for new code it would > be nice if we could try to be more consistent. Always prepend a space > to a left parenthesis, please. I'll check that. > Sorry if that's a lot. It just occured to me while reading your code. > I'm not adamant about the structural change I outlined above, but to > me it seems better to do it that way. What do you think? It will just have to wait a bit, I think. But yes, these are all good suggestions. Regards, Achim. --=20 +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf microQ V2.22R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada