From: Achim Gratz <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: Re: setup
Date: Tue, 30 Jun 2015 17:14:00 -0000 [thread overview]
Message-ID: <87bnfxm83u.fsf@Rainer.invalid> (raw)
In-Reply-To: <20150630164052.GE2918@calimero.vinschen.de> (Corinna Vinschen's message of "Tue, 30 Jun 2015 18:40:52 +0200")
Corinna Vinschen writes:
> Ok, for once. But please make sure that you split the commit into
> functional chunks next time it's so large.
Well, the original patch was a lot smaller and I didn't really expect
that I'd have to replace such a large chunk of the old code to make
things work correctly. I've thought about it some more and I guess I
can split off the search implementation in fromcwd. The meat of the
patch would still be quite large, though.
> And send it to this list, so
> code snippets can be referenced in the review.
Sure.
> A few more nits, mostly on style:
>
> - What I'm missing are code comments in do_local_ini and do_remote_ini
> describing what the new methods do. Yes, the old code didn't have a
> lot of comments either, but it would be nice to have this better
> explained for future reference.
I'll add some.
> - Do you plan to keep the DEBUG_FROMCWD bracketed code in there? If so,
> it should probably just use `#if DEBUG' as elsewhere.
I was using similar code from crypto.cc as a guide. I can remove that
code as it's debugged now. In the long run it'd be better to have
Log(DEBUG_...) calls that get optimized out when doing the final build
indtead of conditional compilation.
> - The call to yydebug=1 is almost invisible now. Please revert that
> to the old
>
> [empty line]
> /*yydebug = 1; */
> [empty line]
OK.
> - ini_decompress as a function name may be a bit misleading. What
> about decompress_ini_file instead?
OK.
> Otherwise it looks ok, especially splitting the code into the new
> functions ini_decompress/decompress_ini_file and check_ini_sig and
> removing IniParseFindVisitor is a blessing.
I'd have really liked to refactor local and remote as well as they are
almost exact copies of each other. I didn't try if file:// URLs would
have worked, maybe they do. If so, the search part for the remote init
would need to be lifted so that both code paths would just process a
list of URLs.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
next prev parent reply other threads:[~2015-06-30 17:14 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 19:37 setup Achim Gratz
2015-05-31 10:24 ` setup Corinna Vinschen
2015-06-01 18:11 ` setup Achim Gratz
2015-06-01 18:34 ` setup Corinna Vinschen
2015-06-01 19:49 ` setup Achim Gratz
2015-06-01 21:06 ` setup Corinna Vinschen
2015-06-02 5:17 ` setup Achim Gratz
2015-06-02 8:29 ` setup Corinna Vinschen
2015-06-02 16:24 ` setup Achim Gratz
2015-06-03 8:19 ` setup Corinna Vinschen
2015-06-03 8:31 ` setup Marco Atzeri
2015-06-03 11:07 ` setup Corinna Vinschen
2015-06-03 12:45 ` setup Eric Blake
2015-06-03 16:51 ` setup Achim Gratz
2015-06-03 17:04 ` setup Yaakov Selkowitz
2015-06-03 17:11 ` setup Achim Gratz
2015-06-08 12:56 ` setup Corinna Vinschen
2015-06-08 13:49 ` setup Corinna Vinschen
2015-06-08 18:34 ` setup Yaakov Selkowitz
2015-06-08 18:47 ` setup Corinna Vinschen
2015-06-08 19:05 ` setup Yaakov Selkowitz
2015-06-08 19:35 ` setup Corinna Vinschen
2015-06-08 18:52 ` setup Achim Gratz
2015-06-06 20:58 ` setup Achim Gratz
2015-06-07 20:21 ` setup Achim Gratz
2015-06-08 13:28 ` setup Corinna Vinschen
2015-06-08 18:07 ` setup Achim Gratz
2015-06-08 19:31 ` setup Corinna Vinschen
2015-06-08 20:54 ` setup Achim Gratz
2015-06-09 9:56 ` setup Corinna Vinschen
2015-06-09 16:54 ` setup Achim Gratz
2015-06-10 8:05 ` setup Corinna Vinschen
2015-06-10 17:47 ` setup Achim Gratz
2015-06-10 18:54 ` setup Corinna Vinschen
2015-06-10 20:50 ` setup Achim Gratz
2015-06-11 10:06 ` setup Corinna Vinschen
2015-06-11 10:11 ` setup Corinna Vinschen
2015-06-11 18:10 ` setup Achim Gratz
2015-06-11 21:03 ` setup Achim Gratz
2015-06-12 10:29 ` setup Corinna Vinschen
2015-06-12 17:05 ` setup Achim Gratz
2015-06-12 17:37 ` setup Corinna Vinschen
2015-06-24 20:00 ` setup Achim Gratz
2015-06-25 8:59 ` setup Corinna Vinschen
2015-06-25 16:40 ` setup Achim Gratz
2015-06-25 20:16 ` setup Achim Gratz
2015-06-26 8:34 ` setup Corinna Vinschen
2015-06-26 18:07 ` setup Achim Gratz
2015-06-26 19:03 ` setup Corinna Vinschen
2015-06-28 13:40 ` setup Achim Gratz
2015-06-29 13:41 ` setup Corinna Vinschen
2015-06-30 4:59 ` setup Achim Gratz
2015-06-30 16:40 ` setup Corinna Vinschen
2015-06-30 17:14 ` Achim Gratz [this message]
2015-06-30 18:42 ` setup Corinna Vinschen
2015-07-01 20:37 ` setup Achim Gratz
2015-07-02 9:10 ` setup Corinna Vinschen
2015-07-02 21:03 ` setup Achim Gratz
2015-07-03 10:14 ` setup Corinna Vinschen
2015-07-11 21:31 ` setup Achim Gratz
2015-07-13 9:44 ` setup Corinna Vinschen
2015-07-14 19:57 ` setup Achim Gratz
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 19:19 setup Achim Gratz
2015-07-29 12:51 ` setup Corinna Vinschen
2015-08-01 15:52 ` setup Achim Gratz
2015-08-03 18:03 ` setup Achim Gratz
2015-08-03 19:07 ` setup Achim Gratz
2015-08-03 20:02 ` setup Achim Gratz
2015-08-03 20:29 ` setup Corinna Vinschen
2015-08-03 20:31 ` setup Achim Gratz
2015-08-03 20:40 ` setup Corinna Vinschen
2015-08-03 20:54 ` setup Achim Gratz
2015-08-03 21:20 ` setup Achim Gratz
2015-08-04 18:35 ` setup Achim Gratz
2015-08-05 8:08 ` setup Corinna Vinschen
2015-08-05 15:42 ` setup Achim Gratz
2015-08-06 10:03 ` setup Corinna Vinschen
2015-08-06 15:58 ` setup Achim Gratz
2015-08-07 19:47 ` setup Corinna Vinschen
2015-08-07 21:05 ` setup Warren Young
2015-08-10 8:44 ` setup Corinna Vinschen
2015-08-10 15:02 ` setup Warren Young
2015-08-11 7:48 ` setup Corinna Vinschen
2015-08-11 19:53 ` setup Warren Young
2015-08-08 5:22 ` setup Achim Gratz
2015-08-10 9:18 ` setup Corinna Vinschen
2015-08-10 16:33 ` setup Achim Gratz
2015-08-10 14:44 ` setup Warren Young
2015-08-10 16:40 ` setup Achim Gratz
2015-08-10 16:45 ` setup Warren Young
2015-08-10 17:00 ` setup Achim Gratz
2015-08-10 17:09 ` setup Warren Young
2015-08-10 18:03 ` setup Achim Gratz
2015-08-10 18:41 ` setup Warren Young
2002-03-04 19:28 setup Robert Collins
2002-03-04 23:38 ` setup Michael A Chase
2002-03-05 8:31 ` setup Brian Keener
2002-02-20 23:10 Setup Robert Collins
2002-02-18 6:12 Setup Robert Collins
2002-02-18 13:06 ` Setup Brian Keener
2002-02-18 17:26 ` Setup Robert Collins
2002-02-18 20:05 ` Setup Christopher Faylor
2002-02-18 20:19 ` Setup Robert Collins
2002-02-18 20:31 ` Setup Brian Keener
2002-02-18 20:34 ` Setup Robert Collins
2002-02-18 20:44 ` Setup Brian Keener
2002-02-18 20:50 ` Setup Robert Collins
2002-02-19 8:53 ` Setup Brian Keener
2002-02-24 3:03 ` Setup Robert Collins
2002-02-18 20:46 ` Setup Christopher Faylor
2002-02-18 20:56 ` Setup Christopher Faylor
2002-02-20 22:45 ` Setup Gary R. Van Sickle
2002-02-20 23:00 ` Setup Christopher Faylor
2002-02-24 3:05 ` Setup Robert Collins
2002-02-24 9:07 ` Setup Christopher Faylor
2002-02-18 20:18 ` Setup Brian Keener
2002-02-18 20:30 ` Setup Robert Collins
2002-02-18 18:48 ` Setup Robert Collins
2002-02-18 19:50 ` Setup Robert Collins
2002-02-22 5:38 ` Setup Brian Keener
2002-02-22 14:46 ` Setup Robert Collins
2002-02-22 19:15 ` Setup Brian Keener
2002-02-22 23:04 ` Setup Christopher Faylor
2002-02-24 2:38 ` Setup Robert Collins
2002-02-27 10:20 ` Setup Brian Keener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnfxm83u.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).