From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mr6.vodafonemail.de (mr6.vodafonemail.de [145.253.228.166]) by sourceware.org (Postfix) with ESMTPS id 901133858C52 for ; Sun, 27 Mar 2022 13:23:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 901133858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nexgo.de Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4KRGjt70kqz1xxL for ; Sun, 27 Mar 2022 13:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexgo.de; s=vfde-smtpout-mb-15sep; t=1648387410; bh=uLjCTXz/R4gUi919ZrRtAblTXHKqjuBQsv5ExycAxz4=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=gvSiY6EQQFxSUyAaSnrscmPgEZX/lGi095nwx3JVYiLYbNY+2BH6jZ4S7xz8bzcmW hYK9kOUyhLLxWwL3D3G0/iTZ8/s9ZXIwbrCrtamwH38BSMmHeltaMJkVZa4OHzRrkn QJlRp9+izexQNZOgDl4Y+bFWqzL2EDkSMMaLObW8= Received: from Gertrud (p5b2f3a9b.dip0.t-ipconnect.de [91.47.58.155]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4KRGjt1QRLz9sLB for ; Sun, 27 Mar 2022 13:23:27 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: cygport References: <87tueb8nry.fsf@Rainer.invalid> <331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk> Date: Sun, 27 Mar 2022 15:22:50 +0200 In-Reply-To: <331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk> (Jon Turney's message of "Mon, 14 Mar 2022 19:06:08 +0000") Message-ID: <87ee2nttqt.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-purgate-type: clean X-purgate: clean X-purgate-size: 984 X-purgate-ID: 155817::1648387410-00000485-1A738C84/0/0 X-Spam-Status: No, score=-3029.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2022 13:23:35 -0000 Jon Turney writes: > A few comments after looking at: > > lib/pkg_info.cygport: implement automatic determination of the > appropriate perl5_0xy requirement > 1. In __list_deps(), this should look at the files list in $@, not at > files in $D, as that causes it to identify a perl5_0xy dependency for > all subpackages, irrespective of which package (if any) contains the > files in the vendor_perl directory. > > 2. This only identifies the perl5_0xy requirement for packages which > own files in the vendor_perl directory, not for packages which contain > executables or shared libraries dynamically linked with > cygperl5_xy.dll. That should at least be mentioned in the patch > commentary. I've fixed both of these on the to-upstream branch I think. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds