From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37652 invoked by alias); 10 Oct 2018 18:37:17 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 37638 invoked by uid 89); 10 Oct 2018 18:37:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=Hx-spam-relays-external:ESMTPA X-HELO: mx009.vodafonemail.xion.oxcs.net Received: from Unknown (HELO mx009.vodafonemail.xion.oxcs.net) (153.92.174.39) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Oct 2018 18:37:07 +0000 Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 07E0CD9B646 for ; Wed, 10 Oct 2018 18:36:59 +0000 (UTC) Received: from Gertrud (unknown [91.47.62.214]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id CAAB1199C61 for ; Wed, 10 Oct 2018 18:36:56 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: Zstandard support for setup References: <874lg0d6l8.fsf@Rainer.invalid> <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> Date: Wed, 10 Oct 2018 18:37:00 -0000 In-Reply-To: <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> (Jon Turney's message of "Wed, 29 Aug 2018 17:42:43 +0100") Message-ID: <87ftxdeji5.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00023.txt.bz2 Jon Turney writes: > This should check for ztd in configure.ac using PKG_CHECK_MODULES, > rather than just assuming -lzstd is going to work. Done. > + using namespace std; > > Please don't Done. https://repo.or.cz/cygwin-setup/local.git/patch/fff4b1448072efe5ebb6549cfe04bc15344a3973 > compress_zstd.h: > > +/* this is the parent class for all compress IO operations. > + */ > > Comment is incorrect Done in the above, additionally remove the same copy&paste comment from two existing files: https://repo.or.cz/cygwin-setup/local.git/patch/abf5afbfce47d1942f6d4c2f62fc8b1566920e2e > I'd suggest keeping potentially useful ones under #ifdef DEBUG/#endif > rather than just removing them all. Later... Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves