public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: cygwin-apps@cygwin.com
Subject: [PATCH] setup spews too many messages
Date: Tue, 31 Jul 2018 19:29:00 -0000	[thread overview]
Message-ID: <87h8kfb3wh.fsf@Rainer.invalid> (raw)


--8<---------------cut here---------------start------------->8---
fix excessive message spewage when package vendor is something other than "cygwin"

Installed packages are getting coerced to vendor "cygwin", so there will
be warnings if the vendor string of the single repo is something other
than that.  Use "@System" like zypper for these and suppress the warning
if it would concern an installed package.

Note: The program logic might now fail to warn about having multiple
vendors providing the same package, I didn't test that yet.

	Modified   package_db.cc
diff --git a/package_db.cc b/package_db.cc
index b74aafd..2921d2f 100644
--- a/package_db.cc
+++ b/package_db.cc
@@ -129,7 +129,7 @@ packagedb::read ()
 
                   // very limited information is available from installed.db, so
                   // we put our best guesses here...
-                  data.vendor = "cygwin";
+                  data.vendor = "@System";
                   data.requires = NULL;
                   data.obsoletes = NULL;
                   data.provides = NULL;
	Modified   package_meta.cc
diff --git a/package_meta.cc b/package_meta.cc
index f765baf..3b578a7 100644
--- a/package_meta.cc
+++ b/package_meta.cc
@@ -184,9 +184,12 @@ packagemeta::add_version (const SolverPool::addPackageData &inpkgdata)
              used to control which packageversion the solver picks. For the
              moment, just warn that you might not be getting what you think you
              should... */
-          Log (LOG_PLAIN) << "Version " << pkgdata.version << " of package " <<
-            name << " is present in releases labelled " << pkgdata.vendor <<
-            " and " << i->Vendor() << endLog;
+          if (pkgdata.vendor != "@System")
+	    {
+	      Log (LOG_PLAIN) << "Version " << pkgdata.version << " of package " <<
+		name << " is present in releases labelled " << pkgdata.vendor <<
+		" and " << i->Vendor() << endLog;
+	    }
         }
 
       versions.erase(i);
--8<---------------cut here---------------end--------------->8---


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

             reply	other threads:[~2018-07-31 19:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 19:29 Achim Gratz [this message]
2018-08-04 14:32 ` Jon Turney
2018-08-04 18:55   ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8kfb3wh.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).