Cygport: How can I ignore duplicated files in packages

Cygport: How can I ignore duplicated files in packages

[Hamish McIntyre-Bhatty]

Hi there,

Today I'm attempting to update my python-imaging package, but I'm now 
finding that cygport has made the warning about duplicated files an error.

The source is at: https://gitlab.com/hamishmb/cygwin-python-imaging

Files are duplicated in these packages because there are .py files for 
each python release in /usr/lib/python3.*.

This doesn't seem to actually break package creation, but I'd like to 
get this reproducing correctly in scallywag, which I think will flag as 
failed because of this error.

I'm not sure whether this indicates that I'm packaging things the wrong 
way. If so, I'd be happy to learn how to improve my packages.

Hamish

Re: Cygport: How can I ignore duplicated files in packages

[Jon Turney]

On 13/09/2022 11:46, Hamish McIntyre-Bhatty wrote:
> Hi there,
> 
> Today I'm attempting to update my python-imaging package, but I'm now 
> finding that cygport has made the warning about duplicated files an error.

I don't think that cygport's handling of duplicated files has changed.

That's not to say that cygport hasn't changed in some way which has 
broken things.

> The source is at: https://gitlab.com/hamishmb/cygwin-python-imaging
> 
> Files are duplicated in these packages because there are .py files for 
> each python release in /usr/lib/python3.*.

I'm not able to reproduce this problem.

Can you give a specific filename, check that it actually was present in 
multiple packages previously, and explain why it needs to be duplicated?

> This doesn't seem to actually break package creation, but I'd like to 
> get this reproducing correctly in scallywag, which I think will flag as 
> failed because of this error.

I'm not sure if what you are saying here.  Is this an error or a warning?

scallywag doesn't do any additional checking beyond that which cygport does.

> I'm not sure whether this indicates that I'm packaging things the wrong 
> way. If so, I'd be happy to learn how to improve my packages.

In general, duplicated files are a bad idea, and we shouldn't allow them.

(although we don't currently have anything which checks for them in e.g. 
setup, so they can unfortunately occur between packages which aren't 
generated by the same cygport)

Re: Cygport: How can I ignore duplicated files in packages

[Achim Gratz]

Hamish McIntyre-Bhatty writes:
> Today I'm attempting to update my python-imaging package, but I'm now
> finding that cygport has made the warning about duplicated files an
> error.

I don't think anything has changed there lately?

> The source is at: https://gitlab.com/hamishmb/cygwin-python-imaging
>
> Files are duplicated in these packages because there are .py files for
> each python release in /usr/lib/python3.*.

A duplicate is a file that shows up at exactly the same path in more
than one package.  These files don't fit that description as files with
the same name are in separate paths, so what is the actual problem?

> This doesn't seem to actually break package creation, but I'd like to
> get this reproducing correctly in scallywag, which I think will flag
> as failed because of this error.

I think you create it yourself here (and analogous for the other Python
versions):

--8<---------------cut here---------------start------------->8---
python36_imaging_CONTENTS="
	--exclude=_imagingtk*
	--exclude=ImageTk*
	--exclude=SpiderImagePlugin*
	${python36_imaging_CONTENTS}
"
--8<---------------cut here---------------end--------------->8---

which seems to package the same files twice in one archive when
expanded.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: Cygport: How can I ignore duplicated files in packages

[Hamish McIntyre-Bhatty]

On 15/09/2022 20:24, Achim Gratz wrote:
> Hamish McIntyre-Bhatty writes:
>> Today I'm attempting to update my python-imaging package, but I'm now
>> finding that cygport has made the warning about duplicated files an
>> error.
> 
> I don't think anything has changed there lately?
> 
>> The source is at: https://gitlab.com/hamishmb/cygwin-python-imaging
>>
>> Files are duplicated in these packages because there are .py files for
>> each python release in /usr/lib/python3.*.
> 
> A duplicate is a file that shows up at exactly the same path in more
> than one package.  These files don't fit that description as files with
> the same name are in separate paths, so what is the actual problem?
> 
>> This doesn't seem to actually break package creation, but I'd like to
>> get this reproducing correctly in scallywag, which I think will flag
>> as failed because of this error.
> 
> I think you create it yourself here (and analogous for the other Python
> versions):
> 
> --8<---------------cut here---------------start------------->8---
> python36_imaging_CONTENTS="
> 	--exclude=_imagingtk*
> 	--exclude=ImageTk*
> 	--exclude=SpiderImagePlugin*
> 	${python36_imaging_CONTENTS}
> "
> --8<---------------cut here---------------end--------------->8---
> 
> which seems to package the same files twice in one archive when
> expanded.
> 
> 
> Regards,
> Achim.

Ah right, okay. I'll see if I can get that fixed. It's strange, because 
I haven't changed this since the last build which didn't have any issues 
at all, but I'll give it another shot.

Hamish