public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* cygport: how to deal with false positives in requires?
@ 2014-05-11 11:05 Achim Gratz
  2014-05-11 18:41 ` Achim Gratz
  0 siblings, 1 reply; 3+ messages in thread
From: Achim Gratz @ 2014-05-11 11:05 UTC (permalink / raw)
  To: cygwin-apps

Hi Yaakov,

Is there a way to tell cygport to not put (some or all) autodetected
dependencies into the requires line in setup.hint?  The reason I ask is
App::cpanminus, which can use quite some number of optional modules
which then all end up in the requires line.  But App::cpanminus can
happily live without them and does in fact minimally need Perl and tar
only.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cygport: how to deal with false positives in requires?
  2014-05-11 11:05 cygport: how to deal with false positives in requires? Achim Gratz
@ 2014-05-11 18:41 ` Achim Gratz
  2014-05-18 16:36   ` Achim Gratz
  0 siblings, 1 reply; 3+ messages in thread
From: Achim Gratz @ 2014-05-11 18:41 UTC (permalink / raw)
  To: cygwin-apps

Achim Gratz writes:
> Is there a way to tell cygport to not put (some or all) autodetected
> dependencies into the requires line in setup.hint?  The reason I ask is
> App::cpanminus, which can use quite some number of optional modules
> which then all end up in the requires line.  But App::cpanminus can
> happily live without them and does in fact minimally need Perl and tar
> only.

In fact, the dependency generation for Perl Distributions isn't working
correctly.  It does not take into account that a newer distribution
installed into vendor_perl does not need a requirement if the one that
came with Perl itself is sufficient.  Also, it often pulls in the
dependencies of such requirements instead of just the first level.  I'm
going to patch this out and generate the dependencies with the cygport
files, doing this properly from within would require some serious
overhaul.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cygport: how to deal with false positives in requires?
  2014-05-11 18:41 ` Achim Gratz
@ 2014-05-18 16:36   ` Achim Gratz
  0 siblings, 0 replies; 3+ messages in thread
From: Achim Gratz @ 2014-05-18 16:36 UTC (permalink / raw)
  To: cygwin-apps

Achim Gratz writes:
> In fact, the dependency generation for Perl Distributions isn't working
> correctly.  It does not take into account that a newer distribution
> installed into vendor_perl does not need a requirement if the one that
> came with Perl itself is sufficient.  Also, it often pulls in the
> dependencies of such requirements instead of just the first level.  I'm
> going to patch this out and generate the dependencies with the cygport
> files, doing this properly from within would require some serious
> overhaul.

That patch was easy and the dependency generation is now moved to the
script that produces the cygort files.

--8<---------------cut here---------------start------------->8---
commit ef4835b2d064ab5acd281280a5a62bd9933d6cae

    suppress auto-generation of Perl dependencies when NO_PERL_DEPS is defined
    
    * lib/pkg_info.cygpart: Do not auto-generate Perl dependencies when
      NO_PERL_DEPS is defined.
    
    Dependency generation for Perl at least is too simplistic and doesn't
    take into account that some modules required or used might actually be
    optional.  For starters, the search order should be the reverse of
    @INC to skip dependencies that are built-in to perl already, but that
    doesn't pick up those modules that are needed with a higher version.

diff --git a/lib/pkg_info.cygpart b/lib/pkg_info.cygpart
index 31297e1c..7f12f130 100644
--- a/lib/pkg_info.cygpart
+++ b/lib/pkg_info.cygpart
@@ -325,7 +325,7 @@ __list_deps() {
                fi
        fi
 
-       if check_prog perl
+       if ( check_prog perl && ! defined NO_PERL_DEPS )
        then
                pldirs=($(perl -e 'print join(" ",@INC)'))
                pldirs+=" ${DEPS_PATH//:/ }"

--8<---------------cut here---------------end--------------->8---



Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-18 16:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-11 11:05 cygport: how to deal with false positives in requires? Achim Gratz
2014-05-11 18:41 ` Achim Gratz
2014-05-18 16:36   ` Achim Gratz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).