From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80393 invoked by alias); 14 Mar 2019 20:25:38 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 80383 invoked by uid 89); 14 Mar 2019 20:25:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=device, HX-Spam-Relays-External:ESMTPA X-HELO: vsmx009.vodafonemail.xion.oxcs.net Received: from vsmx009.vodafonemail.xion.oxcs.net (HELO vsmx009.vodafonemail.xion.oxcs.net) (153.92.174.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 20:25:37 +0000 Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 685EAC03FC for ; Thu, 14 Mar 2019 20:25:34 +0000 (UTC) Received: from Gertrud (unknown [87.185.218.207]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 3730E30008C for ; Thu, 14 Mar 2019 20:25:32 +0000 (UTC) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: bug in procps-ng References: <20190312170311.GL3785@calimero.vinschen.de> <565e4e13-2bea-09a8-6edc-de2f8342a5a0@SystematicSw.ab.ca> <20190313102846.GW3785@calimero.vinschen.de> <87pnquk5g7.fsf@Rainer.invalid> Date: Thu, 14 Mar 2019 20:25:00 -0000 In-Reply-To: <87pnquk5g7.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 13 Mar 2019 19:14:00 +0100") Message-ID: <87sgvpqk3o.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-03/txt/msg00013.txt.bz2 Achim Gratz writes: > That was an exercise in futility. Procps uses system macros to > dissemble the major/minor devices, so of course it's doing the right > thing on Cygwin while using Cygwin macros (I think these are actually > inline functions now). Actually, it didn't -- but I patched it to do so now. We should think a bit about whether or not Cygwin should conform to the /proc/=E2=80=A6/stat definition of Linux with it's peculiar bit allotment f= or the major/minor device numbers, in which case I'll have to change to a versioned #ifdef (I don't particularly want to use a runtime version check). > But your assertion that it should use stat for > finding the tty is probably wrong, there's Cygwin specific code that > looks at /dev/ctty: > > https://gitlab.com/procps-ng/procps/blob/master/proc/devname.c#L303 > > That's used in addition to code that would correctly determine the > devices fromt the stat info, so at the moment I have no idea where the > wheels fall off that wagon. I still don't know where the bug is in the current package, as just building the current version (without my patch that removes the function that uses /proc/ctty) also works correctly. Regards, Achim. --=20 +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves