From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16621 invoked by alias); 11 Jun 2015 18:10:58 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 16611 invoked by uid 89); 11 Jun 2015 18:10:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-in-05.arcor-online.net Received: from mail-in-05.arcor-online.net (HELO mail-in-05.arcor-online.net) (151.189.21.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 11 Jun 2015 18:10:50 +0000 Received: from mail-in-05-z2.arcor-online.net (mail-in-05-z2.arcor-online.net [151.189.8.17]) by mx.arcor.de (Postfix) with ESMTP id 3m6tXQ5t9cz71py for ; Thu, 11 Jun 2015 20:10:46 +0200 (CEST) Received: from mail-in-01.arcor-online.net (mail-in-01.arcor-online.net [151.189.21.41]) by mail-in-05-z2.arcor-online.net (Postfix) with ESMTP id C74FB6F6FFA for ; Thu, 11 Jun 2015 20:10:46 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-01.arcor-online.net 3m6tXQ4t9Kz2lhg Received: from Gertrud (p4FF1DC5A.dip0.t-ipconnect.de [79.241.220.90]) (Authenticated sender: stromeko@arcor.de) by mail-in-01.arcor-online.net (Postfix) with ESMTPSA id 3m6tXQ4t9Kz2lhg for ; Thu, 11 Jun 2015 20:10:46 +0200 (CEST) From: Achim Gratz To: cygwin-apps@cygwin.com Subject: Re: setup References: <20150608132823.GN3416@calimero.vinschen.de> <87oakqnkfi.fsf@Rainer.invalid> <20150608193154.GU3416@calimero.vinschen.de> <878ubtor9g.fsf@Rainer.invalid> <20150609095604.GA4993@calimero.vinschen.de> <874mmghlf8.fsf@Rainer.invalid> <20150610080526.GC31537@calimero.vinschen.de> <871thjtq0m.fsf@Rainer.invalid> <20150610185417.GL31537@calimero.vinschen.de> <87wpzbs2yj.fsf@Rainer.invalid> <20150611100607.GA14763@calimero.vinschen.de> Date: Thu, 11 Jun 2015 18:10:00 -0000 In-Reply-To: <20150611100607.GA14763@calimero.vinschen.de> (Corinna Vinschen's message of "Thu, 11 Jun 2015 12:06:07 +0200") Message-ID: <87vbeu15gd.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-06/txt/msg00086.txt.bz2 Corinna Vinschen writes: > Ok, I took a look. Basically it looks fine, but it seems there's a bug > in terms of sig_fail. Oh yes, that's buggered up. > You're giving sig_fail as argument to fetch_remote_ini. Inside > fetch_remote_ini, you're setting sig_fail, but you never test it. > However, since sig_fail has been given to fetch_remote_ini by value, > not by reference, the caller will never see the change to sig_fail. Yes, that should have been a bool&. > So in the expression > > if (!ini_file && !sig_fail) > > sig_fail is always false. > > I'm also wondering of the new logic at this point. If you fix the above > call by value of sig_fail, the new logic will only continue if there > was no sig test fail. It will not continue if there was no ini file, > as it did before. Why? When I pulled the two conditions into one, I just didn't get the logic right. I'll rework that later. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada