[ATTN Maintainer] csih

[ATTN Maintainer] csih

[Achim Gratz]

While csih is currently orphaned… :-( I still found these bugs:

"Windows 8.1 N with Bing" gets reported as "Windows 8.1 China" (probably
renamed by MS after the fact).

Also:

> /usr/lib/csih/getAccountName.exe 
/usr/lib/csih/getAccountName.exe: error while loading shared libraries: libwinpthread-1.dll: cannot open shared object file: No such file or directory

It seems that either it would need to be linked statically or the
library provided in a place where it can be found.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [ATTN Maintainer] csih

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On Mar 29 22:13, Achim Gratz wrote:
> 
> While csih is currently orphaned… :-( I still found these bugs:

Well, not exactly.  I (grudgingly) took over to make the changes
required for 1.7.34++.  I noted this fact now in cygwin-pkg-maint.

> "Windows 8.1 N with Bing" gets reported as "Windows 8.1 China" (probably
> renamed by MS after the fact).
> 
> Also:
> 
> > /usr/lib/csih/getAccountName.exe 
> /usr/lib/csih/getAccountName.exe: error while loading shared libraries: libwinpthread-1.dll: cannot open shared object file: No such file or directory
> 
> It seems that either it would need to be linked statically or the
> library provided in a place where it can be found.

I *do* take patches...

...and, yes, we should move this and the other cygwin-apps projects to
git as well.  If there wouldn't be these lame time constraints like,
say, onmly 24 hours a day.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ATTN Maintainer] csih

[Achim Gratz]

Corinna Vinschen writes:
>> "Windows 8.1 N with Bing" gets reported as "Windows 8.1 China" (probably
>> renamed by MS after the fact).

Marketing wins this round apparently.  All documentation I can find
still says "country specific Windows variant" and suggests "China" as
the variant name to go with that.  Yet clearly Windows itself knows it
has been named "N with Bing".

>> It seems that either it would need to be linked statically or the
>> library provided in a place where it can be found.
>
> I *do* take patches...
>
> ...and, yes, we should move this and the other cygwin-apps projects to
> git as well.  If there wouldn't be these lame time constraints like,
> say, onmly 24 hours a day.

I just realized I still have the CVS checkout from the script fixes
anyway.  A quick look doesn't reveal any obvious reason why this
executable would be linked against libwinpthread… and indeed if I
compile it on Cygwin it doesn't.  So, no patch required, but a rebuild
is in order.  You might have had LDFLAGS or CFLAGS set while building
the package?

There's another fix that should probably go into the scripts: The
service users should get SeDenyInteractiveLogonRight (they already have
SeDenyRemoteLogonRight).  At least on my Windows7 Pro/64bit laptop the
accounts show up on the login screen otherwise.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [ATTN Maintainer] csih

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

On Mar 31 21:56, Achim Gratz wrote:
> Corinna Vinschen writes:
> >> "Windows 8.1 N with Bing" gets reported as "Windows 8.1 China" (probably
> >> renamed by MS after the fact).
> 
> Marketing wins this round apparently.  All documentation I can find
> still says "country specific Windows variant" and suggests "China" as
> the variant name to go with that.  Yet clearly Windows itself knows it
> has been named "N with Bing".
> 
> >> It seems that either it would need to be linked statically or the
> >> library provided in a place where it can be found.
> >
> > I *do* take patches...
> >
> > ...and, yes, we should move this and the other cygwin-apps projects to
> > git as well.  If there wouldn't be these lame time constraints like,
> > say, onmly 24 hours a day.
> 
> I just realized I still have the CVS checkout from the script fixes
> anyway.  A quick look doesn't reveal any obvious reason why this
> executable would be linked against libwinpthread… and indeed if I
> compile it on Cygwin it doesn't.  So, no patch required, but a rebuild
> is in order.  You might have had LDFLAGS or CFLAGS set while building
> the package?

I'm not doing anything special.  I'm cross-building on Fedora and have
the mingw{32,64}-winpthreads packages installed.  That could be the
reason.  But why it links against  lib*any*pthread beats me, given the
simplicity and non-threadiness of the tool.

> There's another fix that should probably go into the scripts: The
> service users should get SeDenyInteractiveLogonRight (they already have
> SeDenyRemoteLogonRight).  At least on my Windows7 Pro/64bit laptop the
> accounts show up on the login screen otherwise.

Still, https://cygwin.com/acronyms/#PGA?  Really, I mean it.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ATTN Maintainer] csih

[Achim Gratz]

Corinna Vinschen writes:
>> There's another fix that should probably go into the scripts: The
>> service users should get SeDenyInteractiveLogonRight (they already have
>> SeDenyRemoteLogonRight).  At least on my Windows7 Pro/64bit laptop the
>> accounts show up on the login screen otherwise.
>
> Still, https://cygwin.com/acronyms/#PGA?  Really, I mean it.

Sorry, I was temporarily out of round tuits.

Index: cygwin-service-installation-helper.sh
===================================================================
RCS file: /cvs/cygwin-apps/csih/cygwin-service-installation-helper.sh,v
retrieving revision 1.37
diff -r1.37 cygwin-service-installation-helper.sh
3038a3039
>         /usr/bin/editrights -a SeDenyInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&

OK to commit?

BTW, is there some deeper reason to use

        /usr/bin/editrights -a SeAssignPrimaryTokenPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
        /usr/bin/editrights -a SeCreateTokenPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
        /usr/bin/editrights -a SeTcbPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
        /usr/bin/editrights -a SeDenyInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
        /usr/bin/editrights -a SeDenyRemoteInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
        /usr/bin/editrights -a SeServiceLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
        username_got_all_rights="yes"

instead of

        /usr/bin/editrights \
          -a SeAssignPrimaryTokenPrivilege -a SeCreateTokenPrivilege -a SeTcbPrivilege \
          -a SeDenyInteractiveLogonRight -a SeDenyRemoteInteractiveLogonRight \
          -a SeServiceLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
        username_got_all_rights="yes"

?  Because if there is, that seems like a bug in editrights that should
be fixed.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: [ATTN Maintainer] csih

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 2512 bytes --]

Hi Achim,

On Apr  2 11:27, Achim Gratz wrote:
> Corinna Vinschen writes:
> >> There's another fix that should probably go into the scripts: The
> >> service users should get SeDenyInteractiveLogonRight (they already have
> >> SeDenyRemoteLogonRight).  At least on my Windows7 Pro/64bit laptop the
> >> accounts show up on the login screen otherwise.
> >
> > Still, https://cygwin.com/acronyms/#PGA?  Really, I mean it.
> 
> Sorry, I was temporarily out of round tuits.
> 
> Index: cygwin-service-installation-helper.sh
> ===================================================================
> RCS file: /cvs/cygwin-apps/csih/cygwin-service-installation-helper.sh,v
> retrieving revision 1.37
> diff -r1.37 cygwin-service-installation-helper.sh
> 3038a3039
> >         /usr/bin/editrights -a SeDenyInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&

diff -up, please, it's much easier to read.  

> OK to commit?

Yes, please apply.

> BTW, is there some deeper reason to use
> 
>         /usr/bin/editrights -a SeAssignPrimaryTokenPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
>         /usr/bin/editrights -a SeCreateTokenPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
>         /usr/bin/editrights -a SeTcbPrivilege -u ${csih_PRIVILEGED_USERNAME} &&
>         /usr/bin/editrights -a SeDenyInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
>         /usr/bin/editrights -a SeDenyRemoteInteractiveLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
>         /usr/bin/editrights -a SeServiceLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
>         username_got_all_rights="yes"
> 
> instead of
> 
>         /usr/bin/editrights \
>           -a SeAssignPrimaryTokenPrivilege -a SeCreateTokenPrivilege -a SeTcbPrivilege \
>           -a SeDenyInteractiveLogonRight -a SeDenyRemoteInteractiveLogonRight \
>           -a SeServiceLogonRight -u ${csih_PRIVILEGED_USERNAME} &&
>         username_got_all_rights="yes"
> 
> ?  Because if there is, that seems like a bug in editrights that should
> be fixed.

That should work.  IIUC Chuck was trying to check if every single right
has been granted, but the single call to editrights should do the same
thing, given that it calls LsaAddAccountRights and returns an error if
that function returns an error.

Feel free to apply a patch after testing.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ATTN Maintainer] csih

[Achim Gratz]

Corinna Vinschen writes:
> diff -up, please, it's much easier to read.  

I just did a 'cvs diff'…

> Yes, please apply.

Done.

> That should work.  IIUC Chuck was trying to check if every single right
> has been granted, but the single call to editrights should do the same
> thing, given that it calls LsaAddAccountRights and returns an error if
> that function returns an error.
>
> Feel free to apply a patch after testing.

Will try later.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [ATTN Maintainer] csih

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Apr  2 17:15, Achim Gratz wrote:
> Corinna Vinschen writes:
> > diff -up, please, it's much easier to read.  
> 
> I just did a 'cvs diff'…

  $ echo "diff -upN" >> ~/.cvsrc

> 
> > Yes, please apply.
> 
> Done.
> 
> > That should work.  IIUC Chuck was trying to check if every single right
> > has been granted, but the single call to editrights should do the same
> > thing, given that it calls LsaAddAccountRights and returns an error if
> > that function returns an error.
> >
> > Feel free to apply a patch after testing.
> 
> Will try later.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [ATTN Maintainer] csih

[Achim Gratz]

Corinna Vinschen writes:
>> I just did a 'cvs diff'…
>
>   $ echo "diff -upN" >> ~/.cvsrc

Great, done.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Waldorf MIDI Implementation & additional documentation:
http://Synth.Stromeko.net/Downloads.html#WaldorfDocs