* [PATCH cygport] Handle meson configuration options containing spaces
@ 2018-05-13 18:38 Jon Turney
2018-06-07 20:58 ` Yaakov Selkowitz
0 siblings, 1 reply; 2+ messages in thread
From: Jon Turney @ 2018-05-13 18:38 UTC (permalink / raw)
To: cygwin-apps; +Cc: Jon Turney
Similarly to cygconf, cygmeson should protect configuration options
containing spaces from word splitting so that e.g. cygmeson
"-Dstring_option=foo bah" works as expected.
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
---
cygclass/meson.cygclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cygclass/meson.cygclass b/cygclass/meson.cygclass
index a3d7824..f1daf0d 100644
--- a/cygclass/meson.cygclass
+++ b/cygclass/meson.cygclass
@@ -88,7 +88,7 @@ cygmeson() {
--localstatedir=${prefix%/usr}/var \
--sysconfdir=${prefix%/usr}/etc \
--buildtype=plain --wrap-mode=nodownload \
- ${crossargs} ${CYGMESON_ARGS} ${@} ${CHOST} \
+ ${crossargs} ${CYGMESON_ARGS} "${@}" ${CHOST} \
|| error "meson failed"
}
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH cygport] Handle meson configuration options containing spaces
2018-05-13 18:38 [PATCH cygport] Handle meson configuration options containing spaces Jon Turney
@ 2018-06-07 20:58 ` Yaakov Selkowitz
0 siblings, 0 replies; 2+ messages in thread
From: Yaakov Selkowitz @ 2018-06-07 20:58 UTC (permalink / raw)
To: cygwin-apps
On 2018-05-13 13:38, Jon Turney wrote:
> Similarly to cygconf, cygmeson should protect configuration options
> containing spaces from word splitting so that e.g. cygmeson
> "-Dstring_option=foo bah" works as expected.
>
> Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
> ---
> cygclass/meson.cygclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged.
--
Yaakov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-07 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 18:38 [PATCH cygport] Handle meson configuration options containing spaces Jon Turney
2018-06-07 20:58 ` Yaakov Selkowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).