From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta11-sa.btinternet.com [213.120.69.17]) by sourceware.org (Postfix) with ESMTPS id 272E33857348 for ; Tue, 8 Nov 2022 16:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 272E33857348 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-045.btinternet.com with ESMTP id <20221108162147.HXWG16833.sa-prd-fep-045.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Tue, 8 Nov 2022 16:21:47 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139452E426BCF75 X-Originating-IP: [81.153.98.206] X-OWM-Source-IP: 81.153.98.206 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvgedrfedtgdeklecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpegtkfffgggfuffvfhfhjgesmhdtreertdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhephefhieegueektdfgfeekleegvdegffdvjeehvefgfffgudevjeffleevtdffkeefnecukfhppeekuddrudehfedrleekrddvtdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvtdeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopefuthhrohhmvghkohesnhgvgihgohdruggvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.206) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139452E426BCF75; Tue, 8 Nov 2022 16:21:46 +0000 Content-Type: multipart/mixed; boundary="------------e08r0KX6Q8CZMJChstuduZjY" Message-ID: <8a811ecf-38e7-a631-c09e-92ca4d439cc2@dronecode.org.uk> Date: Tue, 8 Nov 2022 16:21:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [Bug] setup regression #2 Content-Language: en-GB To: Achim Gratz , "cygwin-apps@cygwin.com" References: <87pmfn5o2j.fsf@Rainer.invalid> <0c8c757c-4f6b-3b49-5404-99353de48b1b@dronecode.org.uk> <877d1gd83r.fsf@Rainer.invalid> <3f6098ed-0b64-33f2-c8ca-36a92500adbb@dronecode.org.uk> <87pmf2p830.fsf@Rainer.invalid> From: Jon Turney In-Reply-To: <87pmf2p830.fsf@Rainer.invalid> X-Spam-Status: No, score=-1196.7 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------e08r0KX6Q8CZMJChstuduZjY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/10/2022 17:56, Achim Gratz wrote: > I think that setup was essentially treating the install as "for this > user only" since it was created and maintained by a script that can't > affect that option and the fact it was also in group Adminsitroators > didn't actually register until now. Yeah, that seems possible, since some of these changes fix what are arguably bugs in how that works (i.e. I suspect that previously, even when elevated, if only the registry key HKEY_CURRENT_USER\\Software\\Cygwin\\setup\rootdir exists (and not the same key under HKLM), we're going to install for "Just Me", irrespective of what the UI says) > The DACL on the server install changed from conferring access to "Everyone" to > just the install user and SYSTEM IIRC. It doesn't do that on the > (non-domain) build machine at home that runs Win10 Pro. That makes less sense to me. We should always creating an entry in the DACL for 'Everyone' to hold the POSIX permissions for 'other' users. (See win32.cc:NTSecurity::GetPosixPerms() which translates a file mode to a SD) >> As long as there's an option to force it to keep the former behaviour >> things should be OK, but I haven't really checked if and how this is >> possible. > > Unfortunately, there is no such option. I wrote some code for this option (attached), but I have a hard time seeing how it's functionally different from using '-B/'--no-admin'. So, I guess a question is, does running with that option work as expected in your problematic instance? --------------e08r0KX6Q8CZMJChstuduZjY Content-Type: text/plain; charset=UTF-8; name="0001-Add-an-option-to-not-make-files-group-owned-by-Admin.patch" Content-Disposition: attachment; filename*0="0001-Add-an-option-to-not-make-files-group-owned-by-Admin.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhZTU0N2Y1YjRiNDQyMWJmOWI3YjlmMjA0ZWIzZDMwM2NjNmIyNjczIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxqb24udHVybmV5QGRyb25lY29k ZS5vcmcudWs+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAyMjo0NjoyOSArMDAwMApTdWJqZWN0 OiBbUEFUQ0ggc2V0dXBdIEFkZCBhbiBvcHRpb24gdG8gbm90IG1ha2UgZmlsZXMgZ3JvdXAg b3duZWQgYnkKIEFkbWluc3RyYXRvcnMKCkFkZCBhbiBvcHRpb24gdGhhdCwgd2hlbiBlbGV2 YXRlZCwgZG8gbm90IG1ha2UgZmlsZXMgZ3JvdXAgb3duZWQgYnkKQWRtaW5zdHJhdG9ycyAo aS5lIHVzZSB0aGUgcHJpbWFyeSBncm91cCBvZiB0aGUgdXNlciBydW5uaW5nIHNldHVwCmlu c3RlYWQpLgoKRml4ZXM6IDQ5NWIwMTQ4Ci0tLQogcmVzLnBvdCAgICAgICB8IDggKysrKysr LS0KIHJlcy9lbi9yZXMucmMgfCAxICsKIHJlc291cmNlLmggICAgfCAxICsKIHJvb3QuY2Mg ICAgICAgfCA3ICsrKysrKy0KIDQgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9yZXMucG90IGIvcmVzLnBvdAppbmRleCA2 NDA3OWM4Li5lODRjMzRjIDEwMDY0NAotLS0gYS9yZXMucG90CisrKyBiL3Jlcy5wb3QKQEAg LTMsNyArMyw3IEBAIG1zZ2lkICIiCiBtc2dzdHIgIiIKICJQcm9qZWN0LUlkLVZlcnNpb246 IFBBQ0tBR0UgVkVSU0lPTlxuIgogIlJlcG9ydC1Nc2dpZC1CdWdzLVRvOiBcbiIKLSJQT1Qt Q3JlYXRpb24tRGF0ZTogMjAyMi0wOC0yNyAxMjo1NCswMTAwXG4iCisiUE9ULUNyZWF0aW9u LURhdGU6IDIwMjItMTEtMDggMTQ6MzYrMDEwMFxuIgogIlBPLVJldmlzaW9uLURhdGU6IFlF QVItTU8tREEgSE86TUkrWk9ORVxuIgogIkxhc3QtVHJhbnNsYXRvcjogRlVMTCBOQU1FIDxF TUFJTEBBRERSRVNTPlxuIgogIkxhbmd1YWdlLVRlYW06IExBTkdVQUdFIDxMTEBsaS5vcmc+ XG4iCkBAIC0xMSw3ICsxMSw3IEBAIG1zZ3N0ciAiIgogIkNvbnRlbnQtVHlwZTogdGV4dC9w bGFpbjsgY2hhcnNldD1VVEYtOFxuIgogIkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhi aXRcbiIKICJYLUFjY2VsZXJhdG9yLU1hcmtlcjogJlxuIgotIlgtR2VuZXJhdG9yOiBUcmFu c2xhdGUgVG9vbGtpdCAzLjcuMFxuIgorIlgtR2VuZXJhdG9yOiBUcmFuc2xhdGUgVG9vbGtp dCAzLjcuM1xuIgogIlgtTWVyZ2UtT246IGxvY2F0aW9uXG4iCiAKICM6IERJQUxPRy5JRERf U09VUkNFLkNBUFRJT04KQEAgLTEyNDUsNiArMTI0NSwxMCBAQCBtc2dzdHIgIiIKIG1zZ2lk ICJEaXNhYmxlIGNyZWF0aW9uIG9mIGRlc2t0b3Agc2hvcnRjdXQiCiBtc2dzdHIgIiIKIAor IzogU1RSSU5HVEFCTEUuSURTX0hFTFBURVhUX05PX0dST1VQX0NIQU5HRQorbXNnaWQgIldo ZW4gZWxldmF0ZWQsIGRvIG5vdCBtYWtlIGZpbGVzIGdyb3VwIG93bmVkIGJ5IEFkbWluc3Ry YXRvcnMiCittc2dzdHIgIiIKKwogIzogU1RSSU5HVEFCTEUuSURTX0hFTFBURVhUX05PX1JF UExBQ0VPTlJFQk9PVAogbXNnaWQgIkRpc2FibGUgcmVwbGFjaW5nIGluLXVzZSBmaWxlcyBv biBuZXh0IHJlYm9vdCIKIG1zZ3N0ciAiIgpkaWZmIC0tZ2l0IGEvcmVzL2VuL3Jlcy5yYyBi L3Jlcy9lbi9yZXMucmMKaW5kZXggZWY1ZThiMS4uZGFkNWM0NyAxMDA2NDQKLS0tIGEvcmVz L2VuL3Jlcy5yYworKysgYi9yZXMvZW4vcmVzLnJjCkBAIC02ODMsNiArNjgzLDcgQEAgQkVH SU4KICAgICBJRFNfSEVMUFRFWFRfTUlSUk9SX01PREUgIlNraXAgcGFja2FnZSBhdmFpbGFi aWxpdHkgY2hlY2sgd2hlbiBpbnN0YWxsaW5nIGZyb20gbG9jYWwgZGlyZWN0b3J5IChyZXF1 aXJlcyBsb2NhbCBkaXJlY3RvcnkgdG8gYmUgY2xlYW4gbWlycm9yISkiCiAgICAgSURTX0hF TFBURVhUX05PX0FETUlOICJEbyBub3QgY2hlY2sgZm9yIGFuZCBlbmZvcmNlIHJ1bm5pbmcg YXMgQWRtaW5pc3RyYXRvciIKICAgICBJRFNfSEVMUFRFWFRfTk9fREVTS1RPUCAiRGlzYWJs ZSBjcmVhdGlvbiBvZiBkZXNrdG9wIHNob3J0Y3V0IgorICAgIElEU19IRUxQVEVYVF9OT19H Uk9VUF9DSEFOR0UgIldoZW4gZWxldmF0ZWQsIGRvIG5vdCBtYWtlIGZpbGVzIGdyb3VwIG93 bmVkIGJ5IEFkbWluc3RyYXRvcnMiCiAgICAgSURTX0hFTFBURVhUX05PX1JFUExBQ0VPTlJF Qk9PVCAiRGlzYWJsZSByZXBsYWNpbmcgaW4tdXNlIGZpbGVzIG9uIG5leHQgcmVib290Igog ICAgIElEU19IRUxQVEVYVF9OT19TSE9SVENVVFMgIkRpc2FibGUgY3JlYXRpb24gb2YgZGVz a3RvcCBhbmQgc3RhcnQgbWVudSBzaG9ydGN1dHMiCiAgICAgSURTX0hFTFBURVhUX05PX1NU QVJUTUVOVSAiRGlzYWJsZSBjcmVhdGlvbiBvZiBzdGFydCBtZW51IHNob3J0Y3V0IgpkaWZm IC0tZ2l0IGEvcmVzb3VyY2UuaCBiL3Jlc291cmNlLmgKaW5kZXggY2ZlODYwYi4uOTE3NTM0 ZiAxMDA2NDQKLS0tIGEvcmVzb3VyY2UuaAorKysgYi9yZXNvdXJjZS5oCkBAIC0xNTcsNiAr MTU3LDcgQEAKICNkZWZpbmUgSURTX0hFTFBURVhUX0hFQURFUiAgICAgICAgICAgICAgMTU0 NgogI2RlZmluZSBJRFNfSEVMUFRFWFRfRk9PVEVSICAgICAgICAgICAgICAxNTQ3CiAjZGVm aW5lIElEU19IRUxQVEVYVF9OT19XUklURV9SRUdJU1RSWSAgIDE1NDgKKyNkZWZpbmUgSURT X0hFTFBURVhUX05PX0dST1VQX0NIQU5HRSAgICAgMTU0OQogCiAvLyBEaWFsb2dzCiAKZGlm ZiAtLWdpdCBhL3Jvb3QuY2MgYi9yb290LmNjCmluZGV4IGNjYmQ2YWUuLmY4MWM1YzkgMTAw NjQ0Ci0tLSBhL3Jvb3QuY2MKKysrIGIvcm9vdC5jYwpAQCAtMzcsOCArMzcsMTAgQEAKICNp bmNsdWRlICJwcm9wc2hlZXQuaCIKIAogI2luY2x1ZGUgImdldG9wdCsrL1N0cmluZ09wdGlv bi5oIgorI2luY2x1ZGUgImdldG9wdCsrL0Jvb2xPcHRpb24uaCIKIAogU3RyaW5nT3B0aW9u IFJvb3RPcHRpb24gKCIiLCAnUicsICJyb290IiwgSURTX0hFTFBURVhUX1JPT1QsIGZhbHNl KTsKK3N0YXRpYyBCb29sT3B0aW9uIE5vR3JvdXBDaGFuZ2VPcHRpb24gKGZhbHNlLCAnXDAn LCAibm8tZ3JvdXAtY2hhbmdlIiwgSURTX0hFTFBURVhUX05PX0dST1VQX0NIQU5HRSk7CiAK IHN0YXRpYyBDb250cm9sQWRqdXN0ZXI6OkNvbnRyb2xJbmZvIFJvb3RDb250cm9sc0luZm9b XSA9IHsKICAgeyBJRENfUk9PVERJUl9HUlAsICAgICAgICAgICAgICBDUF9TVFJFVENILCAg ICAgICAgICAgQ1BfVE9QICAgICAgfSwKQEAgLTMxMCw3ICszMTIsMTAgQEAgUm9vdFBhZ2U6 Ok9uTmV4dCAoKQogICAgIDw8IChyb290X3Njb3BlID09IElEQ19ST09UX1VTRVIgPyAiIHVz ZXIiIDogIiBzeXN0ZW0iKSA8PCBlbmRMb2c7CiAKICAgaWYgKHJvb3Rfc2NvcGUgPT0gSURD X1JPT1RfU1lTVEVNKQotICAgIG50X3NlYy5zZXRBZG1pbkdyb3VwICgpOworICAgIHsKKyAg ICAgIGlmICghTm9Hcm91cENoYW5nZU9wdGlvbikKKyAgICAgICAgbnRfc2VjLnNldEFkbWlu R3JvdXAgKCk7CisgICAgfQogICBlbHNlCiAgICAgbnRfc2VjLnJlc2V0UHJpbWFyeUdyb3Vw ICgpOwogCi0tIAoyLjM4LjEKCg== --------------e08r0KX6Q8CZMJChstuduZjY--