From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27379 invoked by alias); 24 Feb 2018 15:33:56 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 27368 invoked by uid 89); 24 Feb 2018 15:33:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=installations, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out5-smtp.messagingengine.com Received: from out5-smtp.messagingengine.com (HELO out5-smtp.messagingengine.com) (66.111.4.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Feb 2018 15:33:54 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 72F8120A4D; Sat, 24 Feb 2018 10:33:52 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sat, 24 Feb 2018 10:33:52 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-141-130-67.range86-141.btcentralplus.com [86.141.130.67]) by mail.messagingengine.com (Postfix) with ESMTPA id 021FC7E0ED; Sat, 24 Feb 2018 10:33:51 -0500 (EST) Subject: Re: Remove legacy networking code To: cygwin-apps@cygwin.com, SZAVAI Gyula References: <0dd4274b-fd3a-2857-bdb5-087243444407@dronecode.org.uk> <20180126165636.2944-1-szgyg@ludens.elte.hu> <98f8b35a-90ae-d232-c16f-c2c7144deb6a@dronecode.org.uk> From: Jon Turney Message-ID: <8bbc8bbf-356c-8f44-1e0f-7ff37c85086f@dronecode.org.uk> Date: Sat, 24 Feb 2018 15:33:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <98f8b35a-90ae-d232-c16f-c2c7144deb6a@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-02/txt/msg00047.txt.bz2 On 28/01/2018 21:47, Jon Turney wrote: > On 26/01/2018 16:56, SZAVAI Gyula wrote: >> [PATCH setup 1/5] Remove direct(legacy) connection type >> [PATCH setup 2/5] Rename IDC_NET_IE5 to IDC_NET_PRECONFIG >> [PATCH setup 3/5] Remove NetIO_File >> [PATCH setup 4/5] Add Proxy class >> [PATCH setup 5/5] Remove NetIO_HTTP > > Thanks, this is great. I applied this patch series to setup, with a few tweaks to address my comments. Sorry about the delay and thanks again! > > A few minor comments: > > 1/5: > > It would be nice if you'd said in the patch commentary what will happen > to existing installations which are configured to use direct(legacy) - > they get converted to preconfig. > > 3/5: > > This changes to wininet handling all file access (converting raw paths > into file:// format URLs) > > I had some concerns [1] that this maybe changes the set of malformed > file:// URLs we handle (which is ok, although it would be nice to know > the details), and still doesn't handle correctly formed ones. > > [1] https://cygwin.com/ml/cygwin-apps/2017-05/msg00117.html > > 4/5: > > operator!= could probably use a comment along the lines of "it's only > meaningful to compare host:port if IDC_NET_PROXY" > > It's unclear to me what Proxy::bypass() is doing.  MSDN actually says > "Do not use an empty string", for unclear reasons. > > We can also remove simpsock.{cc,h} and linking with winsock, after this > series.