From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta13-sa.btinternet.com [213.120.69.19]) by sourceware.org (Postfix) with ESMTPS id 759993858D1E for ; Fri, 30 Sep 2022 12:11:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 759993858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-045.btinternet.com with ESMTP id <20220930121146.LTLN16833.sa-prd-fep-045.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Fri, 30 Sep 2022 13:11:46 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139452E3CD5AC09 X-Originating-IP: [81.153.98.187] X-OWM-Source-IP: 81.153.98.187 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehvddggeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedvtdetffekveevjeegheeglefhtdeggfeilefggfdutedufedvgefgieeiffdtveenucfkphepkedurdduheefrdelkedrudekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrudekjedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepuehrihgrnhdrkfhnghhlihhssefuhihsthgvmhgrthhitgfufidrrggsrdgtrgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.187) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139452E3CD5AC09; Fri, 30 Sep 2022 13:11:46 +0100 Message-ID: <8f2b933a-06e3-d2bc-a552-6968147dc5d6@dronecode.org.uk> Date: Fri, 30 Sep 2022 13:11:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Issue with another downstream over DESTDIR builds To: "cygwin-apps@cygwin.com" , Brian Inglis References: <61bc8c6e-ed8f-a812-6c05-9e68c4a0a3c7@SystematicSw.ab.ca> <3436aa36-d661-629e-b704-b4887bb0b60f@SystematicSw.ab.ca> <5a2c3997-6274-59ce-fb1a-630418bc49f0@SystematicSw.ab.ca> <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> <4ea3e2fe-a876-52b9-5f9a-f1da51017620@SystematicSw.ab.ca> Content-Language: en-GB From: Jon Turney In-Reply-To: <4ea3e2fe-a876-52b9-5f9a-f1da51017620@SystematicSw.ab.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3567.6 required=5.0 tests=BAYES_00,BODY_8BITS,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/09/2022 20:15, Brian Inglis wrote: > Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] > > I previously submitted a patch upstream to add DESTDIR when creating > package symlinks so cygport builds work without patches. > > Now another downstream is disputing that, requesting the patch be > reverted, saying that symlink targets are contents and should always be > from the non-DESTDIR native source as per GNU "rules" in the autobook. A link to this discussion would be useful. > We agreed to request other more experienced opinions on this issue from > our support groups and report back. > > I am asking the perhaps more experienced professional maintainers to > provide their considered opinion on this issue, demonstrated by the > reversion patch below. > >> The link's target must not include $(DESTDIR), otherwise this ends up >> included in the shipped link. Linking the theoretical target gives the >> correct result. >> >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -115,7 +115,7 @@ >>        $(INSTALL_DATA) $(srcdir)/definitions.units >> $(DESTDIR)@UDAT-DGkERpxY6iylqvY/pMPnfPU/3Eu2kcEP@public.gmane.org >>        -rm -f $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>        $(INSTALL_DATA) $(srcdir)/currency.units >> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> -    if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >> +    if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >> @CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>        $(INSTALL_DATA) $(srcdir)/locale_map.txt >> $(DESTDIR)@UDAT@locale_map.txt >>        if test $(HAVE_PYTHON) = yes; then \ >>          $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo >> units_cur|sed '$(transform)'`;fi > This patch looks correct. Think of it this way: --prefix etc. configures the location of the installed files, DESTDIR selects a temporary staging directory that the files are placed into (e.g. before packaging) So, targets of symlinks which are absolute paths should not contain DESTDIR.