From: Andrew Schulman <schulman.andrew@epa.gov>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
Date: Tue, 02 May 2017 14:30:00 -0000 [thread overview]
Message-ID: <8u5hgcp1v1cfsm2ch9akhvergr79flcaem@4ax.com> (raw)
In-Reply-To: <b3d1d990-36f6-948f-423f-6129c5cfae0a@dronecode.org.uk>
> On 02/05/2017 14:31, Andrew Schulman wrote:
> >> The values which SRC_URI and PATCH_URI evaluate to should not change
> >> depending on ARCH, as this will make the source package arch-dependent
> >
> > In that case what's the right thing to do when we have arch-specific
> > patches? For example screen has one, for x86_64 only.
>
> You could wrap C code in the patch in #ifdef __x86_64__ / #endif
>
> However, looking at screen-terminfo-autoconf.patch, it would seem to be
> entirely benign to use that on x86.
True. OK, I'll rerelease as 4.5.1-2 with the same source in both arches.
next prev parent reply other threads:[~2017-05-02 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 13:14 [PATCH cygport 0/3] cygport patches Jon Turney
2017-05-02 13:14 ` [PATCH cygport 3/3] Update documentation of all and almostall Jon Turney
2017-05-02 14:29 ` Andrew Schulman
2017-05-02 15:12 ` Jon Turney
2017-05-05 20:45 ` Yaakov Selkowitz
2017-05-02 13:14 ` [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH Jon Turney
2017-05-02 13:31 ` Andrew Schulman
2017-05-02 13:39 ` Jon Turney
2017-05-02 14:30 ` Andrew Schulman [this message]
2017-05-05 22:05 ` Yaakov Selkowitz
2017-05-06 11:32 ` Jon Turney
2017-05-11 12:07 ` Jon Turney
2017-05-02 13:14 ` [PATCH cygport 1/3] Pass DEPEND through to .hint for source package as build-depends: Jon Turney
2017-05-05 20:42 ` Yaakov Selkowitz
2017-05-05 23:54 ` Brian Inglis
2017-05-06 5:39 ` Achim Gratz
2017-05-06 11:03 ` Jon Turney
2017-05-06 16:10 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8u5hgcp1v1cfsm2ch9akhvergr79flcaem@4ax.com \
--to=schulman.andrew@epa.gov \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).