From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by sourceware.org (Postfix) with ESMTPS id 1FD113858D35 for ; Sun, 25 Jun 2023 13:59:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FD113858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=towo.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=towo.net Received: from [192.168.178.44] ([188.96.172.42]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mq33i-1pjMlZ2efq-00n8zk; Sun, 25 Jun 2023 15:59:19 +0200 Message-ID: <9069527f-5b55-699a-1ca2-1c68f87b75ba@towo.net> Date: Sun, 25 Jun 2023 15:59:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [ITP] italic-man To: Jon Turney , "cygwin-apps@cygwin.com" References: <711af07e-46e4-4d3b-b28a-a64e37284d55@towo.net> <58be0826-44fc-4ac1-9d37-f66fdd28ef79@towo.net> <582b84f6-b7e0-9f2b-4b41-828d500b923c@dronecode.org.uk> From: Thomas Wolff In-Reply-To: <582b84f6-b7e0-9f2b-4b41-828d500b923c@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:bzctVwZQTm98l+A4uNxMYpMN8/17zq9/daJ6xvG1tr9FFN83T53 sUPr3lvOZl8GCWNOWGM1f4smFW5kZwuTWBgb6nwZqdSN1vpQlO0cx8UBKYkkG5YPSlt70V7 /lYdFjME3RBrjc61tO4DM5FFzfgad6gpGGAyoWs2By8cOHtt/Q8sZB1te3LIi0P15XjKj7M ccXNKbSm+BMIpE9/wxfEw== UI-OutboundReport: notjunk:1;M01:P0:93WDuJ3ThiY=;NyUrQEcc7xBsFCRYZ7lECrPxP27 lnm8SoUYYrHZEI5eQAyHuDtTEL+1tXQ4Er2pJz3bYvFmY0Ro08wqIyhxfjtlM795byLfcu00v GWJDYNTJ9fi2+LhRGUYAgwK0qXUJmVedCgALfPfiHAyeD8uSlx1rWNRL/iCwGu/oiTvARYvJo j84e8sGRTNHKFido9YH8hj8liuyO+z2ng13hmlA1cj01YArIgADn4uFVyD0OKGgxPfbVtjM8Y QPfJqvWOaUf3G+KxhO0dyaM2f/uXw0hN2eeofmJF8rEiwq6z7RZ979DTH9NDZ0DgukLCsHqdW MUCgVQE/hvEkd4iLvG2oVa82e3vyIa3nbkJJv6db9SUa1fdd1Jmh0aiIZEIwrGCPrJ5MfTHUw Xn/gb2Vh8dzUDVqZDJo2LxXBCOQe0D9mzzCV9IBFzB2bnyioIEMOWLXAvbQivLBh8dIRZ6XgS gFF25s0B2mkLmkDruA+hGBuRvoUS5wBsscSpqCa50Zgs34F2fODiPB+NVjjC+gsg2Er4yygLy 0h0LKROLh3jw4383uK86d3BYZamvNdCdXxd4ZCyTiwCEoZw1PC7sEEGblgMuNzH+6MvSRxc1G /Jog0KPJXu/vgaSvijMjWdPqi+wVvL+zJxKe9HAPh7pxiDNmINL2baXEz8geOujA0kBPzzmAl sgX7dg0lawXGWsoX6602vEoKjYaU/DVyZVtwKfMEkg== X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am 25.06.2023 um 15:36 schrieb Jon Turney: > On 21/06/2023 22:45, Thomas Wolff via Cygwin-apps wrote: >> >> Am 16.02.2023 um 20:17 schrieb Thomas Wolff via Cygwin-apps: >>> >>> Am 16.02.2023 um 19:59 schrieb Jon Turney: >>>> On 21/01/2023 17:04, Thomas Wolff via Cygwin-apps wrote: >>>>> italic-man installs two scripts and hooks them into the workflow >>>>> of the 'man' command so that the italic attribute of manual pages >>>>> is actually displayed as italics in terminals that support it. >>>>> >>>>> cygport file attached >>>> >>>> Thanks very much for having another go at this. >>>> >>>> I'm still not overly keen on postinstall/preremove scripts which >>>> modify a configuration file belonging to another package, so I >>>> think I'm going to defer to Achim on approving this. >>>> >>>> Taking a step back, may I ask a couple of questions? >>>> >>>> - Can this be done as a patch to man-db and/or groff? >>>> >>>> (perhaps with a separate man-italic package which just contains a >>>> marker file which enables the functionality?) >>>> >>>> - (If different) how would this be done in an upstreamable way? >>> Thanks for taking a look. >>> I understand your hesitation but there are a number of zp_ >>> postinstall scripts around that make updates to mandb, mime db, >>> desktop, various caches, maybe crontab. > > There's a difference between updating a cache or db of files which > exist on the filesystem after the package update and modifying a file > which might be overwritten by reinstalling or updating a different > package. > >>> Well, yes, there could be a zp_ script for man that makes this entry >>> to /etc/man_db.conf itself in the presence of the italic-man >>> package. If that's desired and someone else updates man, I will >>> cooperate on this. >>> I think the installation of italic-man does this in an upstreamable >>> way except for the postinstall mechanism of course which seems to be >>> different (if existent at all) everywhere. >>> Thomas >> I've added a zp_man-db-italic.dash postinstall script as a proposal >> for man-db to address your concerns, to be found in the repository >> github.com/mintty/italic-man. However, I find not documentation about >> these zp_ things, it seems they are just all called after each setup. So > > They are briefly covered in [1].  If that's missing some details, > please let me know and I'll see what can be done to improve it. > > [1] https://cygwin.com/packaging-package-files.html#postinstall > >> would it actually make a difference whether the zp_ is a script of >> italic-man or of man-db? I've also added a cygport file to the >> repository so you can try the update if you like. Still interested in your opinion about this question. Also whether it's OK that package italic-man provided a zp script that modified /etc/man_db.conf. >> About your first question >>> - Can this be done as a patch to man-db and/or groff? >> Do you mean the whole thing should not be a separate package at all >> but completely patched into man-db? > > Well, yes, that would avoid all the knots caused by post-install > scripts with uncertain ordering I'm worrying about. I think I have addressed those uncertainties and the problem with the man-db patch is that man-db package maintainers would need to take up the issue... > > Can you explain, in general terms, why this isn't a feature of stock > man-db already? There is option grotty -i in stock man-db but grotty is a tool deeply embedded in the man toolchain and there is no user-friendly documented way to inject this option into the toolchain, other than replacing grotty with a wrapper script which is effectively all my package does. > >> Looking forward to your opinion and that of the man-db package >> maintainer. >> And yes, the hook works on Linux too, so it could be provided somehow >> upstream. > > Thanks continuing to grind away at this. >