From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109055 invoked by alias); 13 May 2016 10:29:46 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 108992 invoked by uid 89); 13 May 2016 10:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=castro, edited, posh, edits X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 13 May 2016 10:29:41 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b1ALc-0000lu-Ej for cygwin-apps@cygwin.com; Fri, 13 May 2016 12:29:32 +0200 Received: from c-69-140-37-22.hsd1.md.comcast.net ([69.140.37.22]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 May 2016 12:29:32 +0200 Received: from schulman.andrew by c-69-140-37-22.hsd1.md.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 May 2016 12:29:32 +0200 To: cygwin-apps@cygwin.com From: Andrew Schulman Subject: Re: [RFC] /etc/shells management (fish, mksh, posh, tcsh, zsh) Date: Fri, 13 May 2016 10:29:00 -0000 Message-ID: <923ajbhksgtuiu12fktfsliguvgjq8e58q@4ax.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Archive: encrypt X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00066.txt.bz2 > On 2016-05-11 14:06, Yaakov Selkowitz wrote: > > On 2016-05-11 12:09, Andrew Schulman wrote: > >>> Am 10.05.2016 um 20:19 schrieb Andrew Schulman: > >>>> Achim, can you please add /bin/fish and /usr/bin/fish to /etc/shells in > >>>> base-files? > >>> > AFAICS this should be a two-step process. > > 1) base-files' default /etc/shells should contain only the shells in a > Base install, namely: > > /bin/sh > /bin/ash > /bin/bash > /bin/dash > /usr/bin/sh > /usr/bin/ash > /usr/bin/bash > /usr/bin/dash > /sbin/nologin Yep. > 2) Then all non-Base shells, namely: > > fish Andrew Schulman > mksh Chris Sutcliffe > posh Jari Aalto > tcsh Corinna Vinschen > zsh Peter A. Castro > > will bump release adding an update_etc_shells call, per the attached > patch, with the path of their shell(s). Agreed. > Attached. Any questions or comments before I make this official? This looks right, except that it edits /etc/shells directly. So if a person edits /etc/shells to remove, say, fish, and fish gets updated, as written this patch will add fish back in. (Why they'd install fish but not want it in /etc/shells I don't know, but it's possible.) Better is to add the new shell to /etc/default/etc/shells, then copy that file over /etc/shells if that file had not been previously edited. > Or, is this just not worth the trouble? What are the consequences of > having shells listed in /etc/shells which aren't on the system? /etc/shells doesn't seem to be very important in Cygwin. And it includes one shell now (pdksh) that doesn't exist in Cygwin, and it's not hurting anything. But it's not a lot of work to do it right, and I think we should. Andrew