From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id EB9263858403 for ; Fri, 14 Jan 2022 21:48:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB9263858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x331.google.com with SMTP id l4so8527939wmq.3 for ; Fri, 14 Jan 2022 13:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=yo1kAwvFRdI1kOXxzCyjWHLzGzKjTJSFXnI1CZ93bNw=; b=VduWegnstC6cXUoco9Wkf/UlpOLSklTnUfCegFvFYl+c9sWoDPGTyTkJXv97HLdd2E DLqnsXM9WEdjm/gnxXmA94T+Yby0328pqorSOXJOliBcliwo/twh0vV7eHD3YM/tq8J1 2RVUlvQ0yZNtHW1u8HAzaKk5tk2kytx5vSjPVeO2hwL5Pi+dix0LDvUOau1pexOH2Dvr y7mtBHKbH14T5pke7mF+hLcDROBqeVbVTCAnQXiReQCijBgKwJI0oPgqRVnc1lIH4FGC 7tyLllqz+eTYEznO3qrPNDjPmPlj7UDIwlKKw4W1l8JcN6ysTsXeUkdSIsUx2nHsJkPk kHlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=yo1kAwvFRdI1kOXxzCyjWHLzGzKjTJSFXnI1CZ93bNw=; b=sQm2xTwQRnGyJICeiQ6IkWdFvauO+gbhsRG9qS8PIzfH2oJx2BXGoSdf11rW7calID DsgMAzG/usTtbeT/ScU85iY+Xq/CV1QQQ32n91j/cXHNpFBWjxSePIuPltjLLwvMv7Nr rdNiQnpk63lG3Zo9FMcQD/ydIiorHgEIFus7P16Ep8VGuatUDXalsTy6aemXjmvKuHGB uIFJXBnzBKVRjtkh0U8vb8soHjEOVoflY6E0k6Ptg2S4u+F19Pr1nbC7mSMTBcXqJ+E1 bdMn+n5PuFr9+4SLKkbpK8qFwzz90Q93BcBdvEDZg/oiI0z5T42LRUnRHSecceq5k7C9 c0Kg== X-Gm-Message-State: AOAM5330TdEFM7mR2ezSWz8j6+8zfdIUVWr5q03j7Yc+yMigWC2ne7gW reDwxjNShUHzFuws96j6m5E9oN0PvbY= X-Google-Smtp-Source: ABdhPJy4lEjmwzApno0Y6w2YF787k9QdsF95GLBVPRQEha0WpuFsyq0JaZGIprtu1pedTesDmbijxQ== X-Received: by 2002:adf:d1cf:: with SMTP id b15mr10074351wrd.323.1642196883930; Fri, 14 Jan 2022 13:48:03 -0800 (PST) Received: from ?IPV6:2001:871:222:9e7c:48d7:2a82:ade6:37e9? (dynamic-2b157gpyee4x8kn3zd-pd01.res.v6.highway.a1.net. [2001:871:222:9e7c:48d7:2a82:ade6:37e9]) by smtp.gmail.com with ESMTPSA id az29sm1741375wmb.31.2022.01.14.13.48.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 13:48:03 -0800 (PST) Message-ID: <93d44ea0-a2d6-a71e-9729-59551c2c32ed@gmail.com> Date: Fri, 14 Jan 2022 22:48:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.] Content-Language: en-US To: cygwin-apps@cygwin.com References: <99eff890-3d7f-7fa9-1f42-d8d611b92ded@gmail.com> <44c5a1de-dbfe-625d-8ff8-049d8047277e@gmail.com> <8e1cdac3-b217-faa6-d0a0-8f8a61c6d2a3@gmail.com> <3a18d77a-0339-0702-fdab-ff40cac8d25a@SystematicSw.ab.ca> From: =?UTF-8?Q?Alois_Schl=c3=b6gl?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 21:48:06 -0000 Am 1/14/22 um 11:09 schrieb Marco Atzeri: > On 12.01.2022 23:59, Alois Schlögl wrote: >> >> >> Am 1/12/22 um 06:47 schrieb Marco Atzeri: >>>> In the meantime, please find below the status for the libb64 and >>>> biosig packages. >>> >>>> Thanks that was helpful. Attached is an updated version for biosig >>>> and libb64. >>>> >>>> cygport libb64.cygport all >>>> cygport biosig.cygport all >>>> >>>> runs now w/o error. How can I test whether result can be installed >>>> and used ? >>> >>> One major problem. >>> Never build in the source directory, the final src.patch >>> must fit with you desired patch. >>> So only what you patched should come out. >>> >>> For this package that does not respect the build in a >>> different directory than source, you shoud start >>> with something like: >>> >>> src_compile() { >>>         cd ${S} >>>         lndirs >>>         cd ${B} >>>         cygautoreconf >>>         cygconf >>>         cygmake >>> } >> >> >> >> I've adapted biosig.cygport accordingly and addressed this in the >> attached version. It runs fine when doing >> >>     cygport biosig.cygport all >> >> runs w/o error. Also testing the package with >> >> tar -C / -xvf >> biosig-2.3.3-1.x86_64/dist/biosig/biosig-tools/biosig-tools-2.3.3-1.tar.xz >> tar -C / -xvf >> biosig-2.3.3-1.x86_64/dist/biosig/libbiosig/libbiosig-2.3.3-1.tar.xz >> tar -C / -xvf >> biosig-2.3.3-1.x86_64/dist/biosig/libbiosig-devel/libbiosig-devel-2.3.3-1.tar.xz >> >> >> and running >>     save2gdf -h >> works fine. >> >> Moreover, I understand now why my libb64.cygport file is not ready. >> ecause libb64 is not necessary for libbiosig's support of Stimfit, >> I'll omit libb64 for now. >> Would you please check whether Biosig is ready to be included in >> cygwin ? >> >> >> Cheers, >>     Alois > > > Hi Alois. > > it is almost fine Hi Marco, thanks for the feedback. > > the only problem I see is that the shared library are build as > >   libbiosig.dll while they should be called cygbiosig.dll >   (probably better cygbiosig-3.dll to handle the SOMANE) > I tried to do that, but run into issue. The exe-files still expect libbbiosig.dll, and do not recognise cygbiosig-3.dll It seems this would require significant changes by upstream, also by other projects that would make use of libbiosig (e.g. stimfit, sigviewer, python-biosig, etc.) Since I do not under stand the purpose of renaming libbiosig to cygbiosig, I'm reluctant to go that route. What kind of problems is this renaming supposed to solve ? Concerning SONAME-versioning, I'd like to avoid this for now, and introduce versioning only when its really needed. In the foreseeable future, I do not expect any changes will be needed that would break the API > please also run the test in the ${B} directory Done, this works without error. Please adapt that change accordingly. > > > I was playing with the CMakeList.txt to see if that was more easy > than your deep patch of the upstream Makefile's > I'm afraid that this "deep patch" is just an accidental artifact. When running configure, all Makefile are rebuild from Makefile.in, The Makefile(s) were packaged just by accident in v2.3.3. But in fact these Makefiles should not have part of the released package. Cheers,   Alois