From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout05.t-online.de (mailout05.t-online.de [194.25.134.82]) by sourceware.org (Postfix) with ESMTPS id ABFB43858CD1 for ; Sun, 10 Mar 2024 15:44:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABFB43858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ABFB43858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.82 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710085453; cv=none; b=VO+RY6zGGpRJr/mmaY8RnAU4xuo7ZIm7pGMD5oWiX2x9GI1ya2N01RvemuEjXrWt4qq30tVFMrp3+UNfqX4OOo295F8AmWuG21ZpgeF0Clh+Aztlv3NxJnjNtGP1tpoVy2kBxdPQucMcnGTx6Vm8rEMaDwx0nECbEaZxSjXjXB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710085453; c=relaxed/simple; bh=+fxZJ2BszjA7qbJ14jOT1su+Uzrmu1UmB4AnFLQCZjI=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=VvxjD/QGDd/gJSpQ2McfUOnKJ0Imro6OSXQ0E00fOWW3Zlnz7ROapCxuXcE7tytAr4PfwgCYygeE9qKOHJyXbtC6NVQ2YXc5UGpnomff39ORTaJI2KL3ieIykQf7JxQHmwXU6eP+Y5s51tHdX4xI5AqD8UQX5bC8GZdiQiyosYE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fwd88.aul.t-online.de (fwd88.aul.t-online.de [10.223.144.114]) by mailout05.t-online.de (Postfix) with SMTP id 045A412133 for ; Sun, 10 Mar 2024 16:44:10 +0100 (CET) Received: from [192.168.2.102] ([87.187.47.57]) by fwd88.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1rjLLL-08jiLY0; Sun, 10 Mar 2024 16:44:07 +0100 Subject: Re: [PATCH cygport] dodoc: Skip a file if a compressed version already exists To: cygwin-apps@cygwin.com References: <44df31e7-793e-83a1-2ba7-a77612b22653@t-online.de> Reply-To: cygwin-apps@cygwin.com From: Christian Franke Message-ID: <95b6afb9-7e24-4541-ba28-74a757006725@t-online.de> Date: Sun, 10 Mar 2024 16:44:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 SeaMonkey/2.53.16 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TOI-EXPURGATEID: 150726::1710085447-C9FF8DC7-83476895/0/0 CLEAN NORMAL X-TOI-MSGID: 9d3b5cd0-695f-4c8a-a5e0-01eac1d92c74 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jon Turney wrote: > On 01/03/2024 13:13, Christian Franke via Cygwin-apps wrote: >> It IMO makes sense to compress large and rarely viewed doc files like >> change logs. This seems to be common practice on Debian etc. >> >> With current cygport, the following results in ChangeLog and >> ChangeLog.gz in the docdir: >> >> src_install() >> { >>    ... >>    dodoc ChangeLog >>    gzip -9 -n "${D}/usr/share/doc/${PN}/ChangeLog" >> } > > Uh, I don't quite see how this patch will change the behavior of this > fragment. > Yes, it actually doesn't change the behavior of this fragment itself. > Even more confusing, why isn't this already doing what you want? > Unless you specify -k/--keep to gzip, the input file is removed, right? Yes - but after this src_install() the file will be re-added by __predoc() unless _CYGPORT_RESTRICT_postinst_doc_ is set. The patch avoids this because __predoc() also uses dodoc().