From: Jon Turney <jon.turney@dronecode.org.uk>
To: Adam Dinwoodie <adam@dinwoodie.org>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITP] libinih
Date: Fri, 13 Jan 2023 14:27:46 +0000 [thread overview]
Message-ID: <95f61c82-c125-9b93-d7b4-58ba95ee2350@dronecode.org.uk> (raw)
In-Reply-To: <20230111231637.dbjlug2kpb2oa47i@lucy.dinwoodie.org>
On 11/01/2023 23:16, Adam Dinwoodie via Cygwin-apps wrote:
> On Wed 11 Jan 2023 at 03:14:20PM +0000, Jon Turney wrote:
>> On 09/01/2023 16:32, Adam Dinwoodie via Cygwin-apps wrote:
>>> As requested at [0], I've offered to package libinih for Cygwin. It has
>>> a BSD license[1] and is already packaged for a bunch of *nix distros,
>>> including Fedora, Debian and Arch[2].
>>>
[...]
>> This looks good, except...
>>
>> I'd ask you to split this into libinih0 and libinih-devel packages.
[...]
>
> Makes sense! Here's a rebuild:
>
> https://github.com/me-and/Cygwin-inih/releases/tag/v56-1-rc2
Thanks.
I added this to your packages.
> NAME=libinih
Since the upstream name is just 'inih', the source package should
probably be named that also.
> libinih0_CONTENTS="\
> usr/bin/*.dll\
> usr/share/\
> "
You probably want to write this glob as '*-0.dll', so that when the
soversion changes, packaging fails, rather than silently ploughing on to
contain a libinit0 containing cyginit-1.dll...
(Or factor out the soversion as variable, or something...)
next prev parent reply other threads:[~2023-01-13 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:32 Adam Dinwoodie
2023-01-11 11:56 ` Lemures Lemniscati
2023-01-11 15:14 ` Jon Turney
2023-01-11 23:16 ` Adam Dinwoodie
2023-01-13 14:27 ` Jon Turney [this message]
2023-01-15 6:12 ` Lemures Lemniscati
2023-01-15 22:49 ` Adam Dinwoodie
2023-01-16 12:41 ` Jon Turney
2023-01-13 14:28 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95f61c82-c125-9b93-d7b4-58ba95ee2350@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=adam@dinwoodie.org \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).