public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Takashi Yano <takashi.yano@nifty.ne.jp>
Cc: cygwin-apps@cygwin.com
Subject: Re: [ITP] btop
Date: Thu, 25 Jan 2024 15:11:12 +0000	[thread overview]
Message-ID: <995db097-a742-48fd-acec-74d8a0b31487@dronecode.org.uk> (raw)
In-Reply-To: <20240125002207.aee9cbe0810b0bfd9e928214@nifty.ne.jp>

On 24/01/2024 15:22, Takashi Yano via Cygwin-apps wrote:
> I'd like to propose a new package btop, which is a feature-rich
> resource monitor. btop is ready for many Linux distributions
> including Fedora.
> 

Thanks.

>  
> +#ifdef __CYGWIN__
> +#define _GNU_SOURCE 1
> +#endif
> +

I'd suggest adding -D_GNU_SOURCE=1 to CPPFLAGS, rather than patching 
this in everywhere it's needed.

(Setting this unconditionally could be added to the build system 
somewhere, which is theoretically upstreamable, since it's only not 
needed on linux for :reasons:)

> +#ifdef __CYGWIN__
> +typedef uint32_t DWORD

Is it not possible to just #include <windows.h> here?  If not, perhaps a 
comment why the definitions are copied would nice.

Otherwise, this looks great. I added this to your packages.


  reply	other threads:[~2024-01-25 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 15:22 Takashi Yano
2024-01-25 15:11 ` Jon Turney [this message]
2024-01-26  3:31   ` Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=995db097-a742-48fd-acec-74d8a0b31487@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).