From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 443 invoked by alias); 15 Sep 2017 15:15:49 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 130944 invoked by uid 89); 15 Sep 2017 15:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=our, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 15:15:47 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1226720BA2; Fri, 15 Sep 2017 11:15:45 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 15 Sep 2017 11:15:45 -0400 X-ME-Sender: Received: from [192.168.1.102] (host31-51-205-109.range31-51.btcentralplus.com [31.51.205.109]) by mail.messagingengine.com (Postfix) with ESMTPA id 9094724605; Fri, 15 Sep 2017 11:15:44 -0400 (EDT) Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> Cc: Ken Brown From: Jon Turney Message-ID: <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> Date: Fri, 15 Sep 2017 15:15:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00021.txt.bz2 On 08/09/2017 19:54, Ken Brown wrote: > Finally, I have a question for you, Jon: You introduced > PrereqChecker::upgrade, which is true if and only if the user selects > Current or Test.  I don't see why this is needed.  I've disabled the use > of it and haven't noticed any ill effects.  Am I missing something? This is supposed to be passed into SolverSolution::update() and used to determine if a SOLVER_UPDATE | SOLVER_SOLVABLE_ALL task is given to the solver, causing all packages to be updated (if possible) (i.e. so 'Keep' doesn't update anything) I guess the UI could be improved to make the choice of 'Keep' or 'Current' ('Update') orthogonal to 'Use test packages?'