From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed
Date: Sun, 10 Jun 2018 20:58:00 -0000 [thread overview]
Message-ID: <9cf11934-a2db-7179-3152-21c55a0b6d64@dronecode.org.uk> (raw)
In-Reply-To: <20180317145955.4944-2-kbrown@cornell.edu>
On 17/03/2018 14:59, Ken Brown wrote:
> The IniDBBuilderPackage destructor contains code that is intended to
> be run after each setup.ini file is processed. But the
> IniDBBuilderPackage variables in do_local_ini() and do_remote_ini were
> declared outside the loop that processed the files. Move the
> declaration inside the loop so that the destructor is called after
> each iteration.
Applied, thanks.
I need to think a bit more about 2 & 3 in this series and the concerns I
had in [1]
[1 ]https://sourceware.org/ml/cygwin-apps/2018-03/msg00026.html
prev parent reply other threads:[~2018-06-10 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 15:00 [PATCH setup 0/3] Improve the handling of packagesource::sites Ken Brown
2018-03-17 15:00 ` [PATCH setup 3/3] Keep track of all known sites for a given version of a package Ken Brown
2018-07-09 18:17 ` Jon Turney
2018-07-09 18:19 ` [PATCH setup 1/2] Add Vendor() accessor method to SolvableVersion Jon Turney
2018-07-09 18:19 ` [PATCH setup 2/2] Keep track of all known sites for a given version of a package Jon Turney
2018-07-10 16:12 ` [PATCH setup 3/3] " Ken Brown
2018-03-17 15:00 ` [PATCH setup 2/3] Internalize the libsolv repo attribute data after each setup.ini Ken Brown
2018-03-17 15:00 ` [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed Ken Brown
2018-06-10 20:58 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf11934-a2db-7179-3152-21c55a0b6d64@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).