From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90821 invoked by alias); 10 Jun 2018 20:58:02 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 90763 invoked by uid 89); 10 Jun 2018 20:58:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=concerns, Hx-spam-relays-external:ESMTPA X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 20:58:00 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A1D10211E9 for ; Sun, 10 Jun 2018 16:57:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 10 Jun 2018 16:57:58 -0400 X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.102] (host31-51-207-186.range31-51.btcentralplus.com [31.51.207.186]) by mail.messagingengine.com (Postfix) with ESMTPA id 4374FE4154 for ; Sun, 10 Jun 2018 16:57:58 -0400 (EDT) Subject: Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed To: "cygwin-apps@cygwin.com" References: <20180317145955.4944-1-kbrown@cornell.edu> <20180317145955.4944-2-kbrown@cornell.edu> From: Jon Turney Message-ID: <9cf11934-a2db-7179-3152-21c55a0b6d64@dronecode.org.uk> Date: Sun, 10 Jun 2018 20:58:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180317145955.4944-2-kbrown@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00010.txt.bz2 On 17/03/2018 14:59, Ken Brown wrote: > The IniDBBuilderPackage destructor contains code that is intended to > be run after each setup.ini file is processed. But the > IniDBBuilderPackage variables in do_local_ini() and do_remote_ini were > declared outside the loop that processed the files. Move the > declaration inside the loop so that the destructor is called after > each iteration. Applied, thanks. I need to think a bit more about 2 & 3 in this series and the concerns I had in [1] [1 ]https://sourceware.org/ml/cygwin-apps/2018-03/msg00026.html