public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: setup: uninstalling an orphaned package
Date: Sun, 10 Jun 2018 20:58:00 -0000	[thread overview]
Message-ID: <9e100a2b-cfeb-a042-8cef-5283a3b66714@dronecode.org.uk> (raw)
In-Reply-To: <2c565a8f-8504-6a66-a94d-3b39ca3b8968@cornell.edu>

On 27/03/2018 20:04, Ken Brown wrote:
> On 3/26/2018 1:55 PM, Ken Brown wrote:
>> In ChooserPage::applyCommandLinePackageSelection() we have the 
>> following code:
>>
>>        bool wanted    = pkg.isManuallyWanted();
>>        bool deleted   = pkg.isManuallyDeleted();
>>        bool basemisc  = (pkg.categories.find ("Base") != 
>> pkg.categories.end ()
>>               || pkg.categories.find ("Orphaned") != 
>> pkg.categories.end ());
>> [...]
>>        bool reinstall = (wanted  || basemisc) && deleted;
>>
>> One strange consequence of this is that if the user tries to uninstall 
>> an orphaned package on the command line, then setup will instead try 
>> to reinstall it.
>>
[...]
> 
> Patch attached.

Applied, thanks.

      reply	other threads:[~2018-06-10 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 17:55 Ken Brown
2018-03-27 19:05 ` Ken Brown
2018-06-10 20:58   ` Jon Turney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e100a2b-cfeb-a042-8cef-5283a3b66714@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).