From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cygwin-apps-return-39265-listarch-cygwin-apps=sources.redhat.com@cygwin.com>
Received: (qmail 91786 invoked by alias); 10 Jun 2018 20:58:14 -0000
Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm
Precedence: bulk
Sender: cygwin-apps-owner@cygwin.com
List-Id: <cygwin-apps.cygwin.com>
List-Subscribe: <mailto:cygwin-apps-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps@cygwin.com>
List-Help: <mailto:cygwin-apps-help@cygwin.com>, <http://sourceware.org/lists.html#faqs>
Mail-Followup-To: cygwin-apps@cygwin.com
Received: (qmail 91776 invoked by uid 89); 10 Jun 2018 20:58:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=strange, H*M:a042, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit
X-HELO: out1-smtp.messagingengine.com
Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 20:58:13 +0000
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])	by mailout.nyi.internal (Postfix) with ESMTP id CADA321221	for <cygwin-apps@cygwin.com>; Sun, 10 Jun 2018 16:58:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])  by compute6.internal (MEProxy); Sun, 10 Jun 2018 16:58:11 -0400
X-ME-Proxy: <xmx:45AdWzwnVLpcpBuGNjnNGRuOu75eOseNu2UxAucMmwIN4HTYZzd89A>
X-ME-Proxy: <xmx:45AdW9kyx9DrRAWxUDvcebBZzdORrcpsDKncniSOrzoCPbJtvF67Qw>
X-ME-Proxy: <xmx:45AdW8HDNhdIa1NZowf5FaOIAxmFjn-i0kKC7r0eyxblFMEEVvk3Bw>
X-ME-Proxy: <xmx:45AdW3srrPOkvUTv5cC2XX8ZWnaIln7HWNCKAzEW98Tl0s1vgwi6FQ>
X-ME-Proxy: <xmx:45AdW3lATvfY28vfYbYnF3f8Aquyrtk_iu6VjxCO0_-qrTXntbFunw>
X-ME-Proxy: <xmx:45AdW1wF-nztGecLSnUcPu8PaEbe0urigHY8zDkHkyJgQe_NBoNhhA>
X-ME-Sender: <xms:45AdWwKFIpmE_VdSB3NTv4vmuX6YksSYo5YW51dR9QdvrsyAeDTb-w>
Received: from [192.168.1.102] (host31-51-207-186.range31-51.btcentralplus.com [31.51.207.186])	by mail.messagingengine.com (Postfix) with ESMTPA id 6FCE3E464A	for <cygwin-apps@cygwin.com>; Sun, 10 Jun 2018 16:58:11 -0400 (EDT)
Subject: Re: setup: uninstalling an orphaned package
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
References: <a384c4a5-6ce5-6633-1719-64589cc67673@cornell.edu> <2c565a8f-8504-6a66-a94d-3b39ca3b8968@cornell.edu>
From: Jon Turney <jon.turney@dronecode.org.uk>
Message-ID: <9e100a2b-cfeb-a042-8cef-5283a3b66714@dronecode.org.uk>
Date: Sun, 10 Jun 2018 20:58:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <2c565a8f-8504-6a66-a94d-3b39ca3b8968@cornell.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-06/txt/msg00011.txt.bz2

On 27/03/2018 20:04, Ken Brown wrote:
> On 3/26/2018 1:55 PM, Ken Brown wrote:
>> In ChooserPage::applyCommandLinePackageSelection() we have the 
>> following code:
>>
>>        bool wanted    = pkg.isManuallyWanted();
>>        bool deleted   = pkg.isManuallyDeleted();
>>        bool basemisc  = (pkg.categories.find ("Base") != 
>> pkg.categories.end ()
>>               || pkg.categories.find ("Orphaned") != 
>> pkg.categories.end ());
>> [...]
>>        bool reinstall = (wanted  || basemisc) && deleted;
>>
>> One strange consequence of this is that if the user tries to uninstall 
>> an orphaned package on the command line, then setup will instead try 
>> to reinstall it.
>>
[...]
> 
> Patch attached.

Applied, thanks.