From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-044.btinternet.com (mailomta8-re.btinternet.com [213.120.69.101]) by sourceware.org (Postfix) with ESMTPS id 5DF68396E41A for ; Sat, 17 Sep 2022 12:27:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DF68396E41A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-044.btinternet.com with ESMTP id <20220917122737.GHUW3224.re-prd-fep-044.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Sat, 17 Sep 2022 13:27:37 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE83A092D8E X-Originating-IP: [81.153.98.187] X-OWM-Source-IP: 81.153.98.187 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvvddgheegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgfeludfggefhteetueelieeltddufeevieduiefgudelueektdeutefftedvheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepkedurdduheefrdelkedrudekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrudekjedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrtghpthhtohepphhurhhplhgvrghrmhgrughilhhlohejjeesphhrohhtohhnrdhmvg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.187) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE83A092D8E; Sat, 17 Sep 2022 13:27:37 +0100 Message-ID: <9e4a2d4b-528e-f19f-048f-cc07f824c47a@dronecode.org.uk> Date: Sat, 17 Sep 2022 13:27:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Cygport Bug: "find: No such file" Errors When Packaging Content-Language: en-GB To: William Hu , "cygwin-apps@cygwin.com" References: From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1191.8 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15/09/2022 20:38, William Hu via Cygwin-apps wrote: > Hello, > [...] > > Cygport checks one more time to make sure mldir exists in the package being built > (this second check is why those errors are hard to trigger on a non-OCaml package) > and then calls `find` on both ${D}${mldir} and ${mldir}. Of course, since the > *real* /usr/lib/ocaml won't exist if OCaml isn't installed on your actual system > when you build it, find will output an error when run on those two directories. > > Two ways to fix this would be to either remove the ${mldir} argument from find or > test if ${mldir} exists and set it to the empty string if it doesn't. The second > would likely preserve compatibility if there exist packages that depend on find > searching both directories. The buggy test was added in > . > Does anyone else have any insights or suggestions or does the above fix sound > reasonable? I think just dropping ${mldir} would prevent cygport from detecting the dependencies of an ocaml library (other ocaml libraries, or ocaml itself?), but the second alternative sounds acceptable. Patches welcome, as always :)