From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by sourceware.org (Postfix) with ESMTPS id B9C563858403 for ; Sat, 6 Jan 2024 22:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9C563858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=SystematicSw.ab.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9C563858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704579308; cv=none; b=l+AzXnuG1dZpju6BwsMv7qmdnaBWJFh1yq/AE3sqPf6LHB6Wfsb/o/R3xS4pxwzz+FjXt42Zn7nX7eGlJbpUrL6I2QYNnjrOHh0u6lgx4ohIXsGQFM9NPM/UuRR4jfATdAMJadCSPLn0TDkjtMiUkmldTdUnndPS1+QRa8/ifgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704579308; c=relaxed/simple; bh=pRXHomqA/yj30JixwxesgyPVTfI5rJSrV1XN4G2kEiw=; h=Message-ID:Date:MIME-Version:From:Subject:To; b=GXTi0PY1K4hJbWpZwmRzP17WlspqO09qCg96P7cC/nDhKpEIQTSR1s6O7M+36RO5f4VA2MbdgXpyDgBLm92hvGdsz5xBjB/27gnLOmbH2lb6wjKmxhm1AOyj9gCIzqriDv1qL0LESDzipqn6e0d0hqCMv0VlCT4C04ywXw7sZtw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46566A02DF for ; Sat, 6 Jan 2024 22:15:04 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: Brian.Inglis@SystematicSW.ab.ca) by omf09.hostedemail.com (Postfix) with ESMTPA id C9F5720025 for ; Sat, 6 Jan 2024 22:15:02 +0000 (UTC) Message-ID: <9e758c07-672f-47da-9a70-1c4d379c8b50@SystematicSw.ab.ca> Date: Sat, 6 Jan 2024 15:15:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Brian Inglis Reply-To: cygwin-apps@cygwin.com Subject: Re: github scallywag cygport src_patch_apply_hook and autoconf2.7 install issues Content-Language: en-CA To: cygwin-apps@cygwin.com References: <44789b67-c629-43a2-ba2a-29598f40b62e@SystematicSW.ab.ca> <7c2eb119-6010-41dc-a4c0-b53d59923133@dronecode.org.uk> Organization: Systematic Software In-Reply-To: <7c2eb119-6010-41dc-a4c0-b53d59923133@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: r689yggtstq5autx5pzw5az8knijppob X-Rspamd-Server: rspamout03 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Rspamd-Queue-Id: C9F5720025 X-Session-Marker: 427269616E2E496E676C69734053797374656D6174696353572E61622E6361 X-Session-ID: U2FsdGVkX1/RkOlFHewu7U2ITW4KXYefXyxjJFs724g= X-HE-Tag: 1704579302-494362 X-HE-Meta: U2FsdGVkX1/ru60tNkdeg6YCSWhZuPFnLgdgAFWMEZGqH+Puz5uuwxdhjyfS9Op7uaxG6/K7i69XeGA/QWw+qvBrjG0DHFRDLEq0Yd+O2e1gmESm4vaanl6UWnlPaQdphJevyNugiEspvfuMfob6y1Z6Otz/Kk/9fRy9r446wHfdrevHQlQXYSh+avGyzLpAHdi1Zwe8tfytrjlriY5V3cvoGmLkeZYEJu3xKvbo1i+SuStv/ziGHu+veyaLYAorhLSO3AHD99Iodif1Grbsb8/c5y6V9+i/3MuIkwxHc2TiUuZL1jpQnHBFr/AsgVQTAGB+Tid5xR1QMLavTNCccIHKjip17eeVL/yXgyUrU0AnWX2fTq5xzh71G6xpusuObZ0x4omIY6R4mG5tGeuWiQ== X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-01-06 14:16, Jon Turney via Cygwin-apps wrote: > On 06/01/2024 20:10, Brian Inglis via Cygwin-apps wrote: >> Updating gsasl to 2.2.1 local package build runs fine, but github scallywag >> now fails in two places: >> >> - cygport src_prep src_patch_apply_hook now fails to find patch file passed as >> $1: > I've looked at the cygport, but what you're doing here is very confusing. > > Even with the poor state of the documentation for that hook [1], the fact that > this hook doesn't take any care over the result it returns is a red flag. > > [1] https://cygwin.github.io/cygport/src_prep_cygpart.html#src_patch_apply_hook > > (So it seems like maybe it should 'patch || error', and then return 0) > > It seems like this cygport is written making some assumption about the current > directory when this hook is run, that it's the top-level directory containing > the patch files. > > I could understand that's maybe been accidentally changed from a previous > version with some other change to cygport, but I don't quite understand how that > can be true locally. > > However, it's certainly not guaranteed, because this hook was not designed for > you to do your own patch application like this in. > > All that said: If you write '${top}/$1' it works for me, but you absolutely > shouldn't be relying on undocumented cygport internals like that... Thanks Jon, The issues with using these hooks is a given! I will try that path in the cygport hook, locally and in scallywag. Is there some other way in which I could structure the patch to apply to the out of tree installed gtk-doc makefiles prior to the build without using the hook? The issue with gtk-doc failing this build was discussed when found, in -apps 2022-09-29/30, and applying the patch to its makefiles seemed to be the best way to handle it at the time. I submitted gsasl and gtk-doc patches upstream at the time but had more check FAILs than PASSes after updating gtk-doc. >> ``` >>  >>> Preparing gsasl-2.2.1-1.x86_64 >>  >>> Unpacking source gsasl-2.2.1.tar.gz >> patch -b /usr/share/gtk-doc/data/gtk-doc.flat.make >> gsasl-2-gtk-doc-make-pdf-imgdir.patch >> patch: **** Can't open patch file gsasl-2-gtk-doc-make-pdf-imgdir.patch : No >> such file or directory >> patch -b /usr/share/gtk-doc/data/gtk-doc.make >> gsasl-2-gtk-doc-make-pdf-imgdir.patch >> patch: **** Can't open patch file gsasl-2-gtk-doc-make-pdf-imgdir.patch : No >> such file or directory >> patch -b /usr/share/gtk-doc/data/gtk-doc.no-xslt-flat.make >> gsasl-2-gtk-doc-make-pdf-imgdir.patch >> patch: **** Can't open patch file gsasl-2-gtk-doc-make-pdf-imgdir.patch : No >> such file or directory >> patch -b /usr/share/gtk-doc/data/gtk-doc.no-xslt.make >> gsasl-2-gtk-doc-make-pdf-imgdir.patch >> patch: **** Can't open patch file gsasl-2-gtk-doc-make-pdf-imgdir.patch : No >> such file or directory >> *** Warning: patch gsasl-2-gtk-doc-make-pdf-imgdir.patch skipped by >> src_patch_apply_hook >>  >>> Preparing working source directory >> ``` >> >> - autoconf2.7 is not found, although it is in cygport dependencies, installed >> in step 4 cygwin install action, with 42 dependencies expanded to 232 install >> tasks, and package BUILD_REQUIRES, with 29 dependencies expanded to 259 >> install tasks, excluding autoconf, but build fails: >> ``` >>  >>> Compiling gsasl-2.2.1-1.x86_64 >> *** ERROR: autoconf2.7 is required to build this package >> ``` > This seems to be some breakage from today's update to autoconf 2.72. > > Top Men, working on, etc. Thanks, I just noticed the release and wrapper update announcements. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut -- Antoine de Saint-Exupéry