From: Hamish MB <hamishmb@live.co.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Updated cygport for for wxwidgets 3.0 package
Date: Sat, 07 Sep 2019 18:48:00 -0000 [thread overview]
Message-ID: <AM6PR04MB6101602A509DF2F8E7652FEEE7B50@AM6PR04MB6101.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <b22bda6f-9886-8c7d-9b82-833d653f6e82@dronecode.org.uk>
Yes, I realise now that I should have done that. I apologise if I caused
any irritation or offence.
I guess I might as well provide explanations now for the sake of
completeness, if nothing else.
1: This was a mistake, and I got confused because I was attempting to
build wxPython at the same time, and the patches for that no longer
apply because the build system has changed.
2: This reflects the new version number of wxwidgets - 3.0.4.
3: I needed these in order to build without the patches. I'm not sure
why, but these aren't needed when the patches are used. This is
documented at https://forums.wxwidgets.org/viewtopic.php?f=19&t=46091
4: That was another mistake, I didn't realise I did that.
5: I looked in the location the tests were meant to be, but they weren't
there, so the test section didn't work. Perhaps this has something to do
with the patches as well?
All that said, I should also have made it clear that I didn't think the
patch was 100% ready - I thought more work was going to be required at
any rate.
Hamish
On 07/09/2019 16:07, Jon Turney wrote:
> On 05/09/2019 17:36, Hamish MB wrote:
>> Attached is a patch from git format-patch to upgrade the wxwxidgets
>> version to 3.0.4. Next up I'll try to make a package for wxPython 4, but
>> I have to get it to build first.
>
> Thanks for attempting this.
>
> Going forward, please consider that this patch does (at least) the
> following things:
>
> * Removes existing patches
> * Updates the version number
> * Adds '-D_XOPEN_SOURCE=500 -D_DEFAULT_SOURCE' to CPPFLAGS
> * Disables the webviewwebkit configuration option
> * Removes the tests
>
> It makes it a lot easier for someone to evaluate your patch if you
> give reasons for the changes in the patch commentary.
next prev parent reply other threads:[~2019-09-07 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:37 Hamish MB
2019-09-05 19:35 ` Yaakov Selkowitz
2019-09-05 19:42 ` Hamish MB
2019-09-05 21:19 ` Yaakov Selkowitz
2019-09-06 8:58 ` Hamish MB
2019-09-07 15:08 ` Jon Turney
2019-09-07 18:48 ` Hamish MB [this message]
2019-09-07 19:12 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB6101602A509DF2F8E7652FEEE7B50@AM6PR04MB6101.eurprd04.prod.outlook.com \
--to=hamishmb@live.co.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).