public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Adam Dinwoodie <adam@dinwoodie.org>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITP] passwdqc 2.0.2
Date: Sun, 23 Oct 2022 20:19:04 +0100	[thread overview]
Message-ID: <CA+kUOa=tKkCFohZKoYOxCBWUa_GxZFsi0MnKqLoQj-vka6yE=Q@mail.gmail.com> (raw)
In-Reply-To: <0fe82c85-b6f2-6c9a-6529-dbf42647498a@acm.org>

On Sun, 23 Oct 2022 at 20:13, Chad Dougherty wrote:
> On 2022-10-23 13:42, Adam Dinwoodie wrote:
> >> .hint and .cygport files are attached and can also be found here along
> >> with built packages:
> >> https://github.com/crd477/passwdqc-cygport
> >
> > Mostly looks good to me, but I think there are a couple of errors:
> >
> > - etc/passwdqc.conf and usr/share/man/man5/passwdqc.conf.5.gz look to
> > me like they belong in the libpasswdqc0 package
> >
>
> Ah, you're right.  Good catch.  Fixed in the working repo I mentioned
> above.
>
> > - The usr/share/man/man3/passwdqc_* man pages are all empty
> >
>
> I can't reproduce this and they all look OK in my local environment.  By
> any chance do you have a pointer to a public artifact where it occurs?
>
> To be sure, these man pages should be identical for each passwdqc
> function but they should not be empty.

You can see it in the packaged files from your build, at
https://github.com/crd477/passwdqc-cygport/raw/main/passwdqc-2.0.2-1.x86_64/dist/passwdqc/libpasswdqc-devel/libpasswdqc-devel-2.0.2-1.tar.xz

> Thanks for reviewing this.  I really appreciate it, especially while I'm
> still getting familiar with this process.

Glad to help, and thank you for getting involved :)

  reply	other threads:[~2022-10-23 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 21:42 Chad Dougherty
2022-10-23 12:55 ` Jon Turney
2022-10-23 17:42 ` Adam Dinwoodie
2022-10-23 19:13   ` Chad Dougherty
2022-10-23 19:19     ` Adam Dinwoodie [this message]
2022-10-23 19:30       ` Chad Dougherty
2022-10-23 19:41         ` Adam Dinwoodie
2022-10-25 15:42           ` Chad Dougherty
2022-10-30 13:15 ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+kUOa=tKkCFohZKoYOxCBWUa_GxZFsi0MnKqLoQj-vka6yE=Q@mail.gmail.com' \
    --to=adam@dinwoodie.org \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).