From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by sourceware.org (Postfix) with ESMTPS id 37D3A3858C83 for ; Sat, 22 Apr 2023 12:05:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37D3A3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa33.google.com with SMTP id 71dfb90a1353d-4436189d2a9so994518e0c.1 for ; Sat, 22 Apr 2023 05:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682165104; x=1684757104; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=eICWgdzHImFjlB7WndDpDjQtAHZMwq8IzJymi03HThg=; b=h2zsAWcrqPDSBREyJ1Z31XRZ8QZ6URygBLyb+QIdDt2pLyg+5AT/yww7MhOKCTDJSk 051k47l64oq+WfRYCaoQl94DrMd6bvOWc5auWFvWQxQ9nUsw6Ar+qosI+ps7VbUoWF1+ +hUhVEnlKS2GVlBeoBwvcPfVJoSoOj4r9v5Hru/3WyCzZ0QDyv8wL3JJzeN942oefxXu v+K9aCkxTkjRhRa+3m+N5+jSvoANR4/kfjlInycGkkctG/7qko0UsEh/b/VM7tHTn3m7 YrlKA5SmwnuCG4uEryGxHffYNKqp4gMhc6oERpUsfl0qheGIXRzzYk9UKg5LPZ1zFDvI 4ZCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682165104; x=1684757104; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eICWgdzHImFjlB7WndDpDjQtAHZMwq8IzJymi03HThg=; b=hQvKspGjcv4KCp5x1c8p+jX8xRLh+GT99/vHQH8BqRpMV17zR85wQTnc9d9sX2Qjfn tw4B5lYoeP3Jrg4SUZYvsspQ23LITUFGkG54Z8kZkPrHrTBTWecb+l8Zhjwaj3dFnZ/m tgG3K+jgBMW5vaV65Lq58OwbWqlIWlcSsiuPJ/34Rb1/VLQ7TGaJcxkgMCT84+19ZuHX lrtAVAj4UG85aXmQZVJz8KmdGWVRnGWEGqMVd1WiP3i1DDi8HWqmBuBnRA1MLl2/rGfc 9kQL0m0EGLNA7jPSF3iIdYChtkEGTrWWwgL6kpt2n42GID46ayqZ8whSZ4Vpd1SVH3Ly wG8g== X-Gm-Message-State: AAQBX9c/SXFkE7n05fy0WfN/OG18CdZNSwwH0ldMok+fbSJ2a/PBE5q0 PK8Dbi928/u9KKx0cFisWS2p8wdANRZfmjOrOxsyjF2JDZU21g== X-Google-Smtp-Source: AKy350ZicRHSGVNs2lJuS1kpfMBFCasebdh/ZB2eP84jKwJ0lBwaHsMmt805xszvgalN8hNZjxUZgKUP5E5Y1Bxvqpc= X-Received: by 2002:a1f:3f8d:0:b0:440:333a:1a60 with SMTP id m135-20020a1f3f8d000000b00440333a1a60mr1653960vka.8.1682165104015; Sat, 22 Apr 2023 05:05:04 -0700 (PDT) MIME-Version: 1.0 References: <55c06590-b192-9c43-c20f-a1967abf920c@gmail.com> <8a06d928-4788-2290-581b-f22f881af7b2@dronecode.org.uk> In-Reply-To: From: Daisuke Fujimura Date: Sat, 22 Apr 2023 21:04:27 +0900 Message-ID: Subject: Re: [ITA] ruby 3.2.2 To: cygwin-apps@cygwin.com Content-Type: multipart/mixed; boundary="0000000000007a96cf05f9eb9514" X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007a96cf05f9eb9514 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > >>>> Are you planning to adopt also the ruby-* sub-packages ? I intend to do that. > > 2. Modify cygport and release it. > > - Add code to detect dependencies on `ruby_xy`. > > - It is similar to the process for `perl5_xy0`. > > - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.c= ygpart#L442 > > - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.c= ygpart#L639 > > Yes. > > I'm not asking you to do this work though, unless you really feel like it= :) Please review the attached diff. > > - Add `ruby_PROVIDES=3D"ruby_${${VERSION%.*}//./}"` to ruby.cygpor= t. ``` /tmp/cygport-ruby/ruby.cygport: line 49: ${${VERSION%.*}//./}: bad substitu= tion ``` Is the warning being displayed because $VERSION (=3D3.2.2) starts with a nu= mber? On Sat, Apr 22, 2023 at 5:06=E2=80=AFAM Jon Turney wrote: > > On 21/04/2023 20:36, Daisuke Fujimura via Cygwin-apps wrote: > > Thank you for your review. > > > > Based on your review, I understand that the following steps are necessa= ry. > > > > Could you please let me know if it is correct? > > > > 1. Release `ruby-2.6.4-2`. > > - Add `ruby_PROVIDES=3D"ruby_${${VERSION%.*}//./}"` to ruby.cygpor= t. > > - The value of this variable will be `ruby_26`. > > - `provides: ruby_26` is added to `ruby-2.6.4-2.hint`. > > This isn't needed. I've retroactively modified the existing 2.6.4-1 and > 2.6.3-1 packages to have this provide. > > > 2. Modify cygport and release it. > > - Add code to detect dependencies on `ruby_xy`. > > - It is similar to the process for `perl5_xy0`. > > - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.c= ygpart#L442 > > - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.c= ygpart#L639 > > Yes. > > I'm not asking you to do this work though, unless you really feel like it= :) > > > 3. Rebuild `ruby-*` subpackages. > > Again, this isn't needed as I can retroactively modify existing packages. > > > - The new cygport adds `depends: ruby_26` to the hint. > > I've retroactively added this to the packages listed below, which > install into /usr/lib/ruby/vendor_ruby/2.6/ a .so linked to cygruby260.dl= l: > > > - (Question) Does a gem that has no dependencies on `cygruby*.dll` > > need to rebuild? > > I don't really know enough about ruby to answer that question, but > I don't think so. > > > 4. Release `ruby-3.2.2-1`. > > - The value of `provides` becomes `ruby_32`. > > - Packages that depend on `ruby_26` will no longer be installable. > > 5. Rebuild `ruby-*` subpackages. > > - The rebuild adds `depends: ruby_32` to the hint. > > Yes. > > The idea is that this will ensures that packages which are installed > together will work together, going forwards. > > > On Fri, Apr 21, 2023 at 1:13=E2=80=AFAM Jon Turney wrote: > >> On 20/04/2023 11:50, Jon Turney via Cygwin-apps wrote: > >>> On 20/04/2023 04:28, Marco Atzeri via Cygwin-apps wrote: > >>>> On 20.04.2023 00:42, Daisuke Fujimura via Cygwin-apps wrote: > >>>>> Hello, > >>>>> > >>>>> =3D=3D=3D=3D > >>>>> > >>>>> Cygportfile: > >>>>> - > >>>>> https://cygwin.com/git-cygwin-packages/?p=3Dgit/cygwin-packages/pla= yground.git;a=3Dshortlog;h=3Drefs/heads/ruby > >>>>> > >> > >> Looks fine. Thanks very much for updating this! > >> > >>>>> Packages, logs: > >>>>> - https://github.com/cygwin/scallywag/actions/runs/4743191979 > >>>> > >>>> > >>>> all yours > >>>> > >>>> Are you planning to adopt also the ruby-* sub-packages ? > >>>> > >>>> Regards > >>>> Marco > >>> > >>> I have a concern about how this changes a soversioned dll inside the > >>> package (from cygruby260.dll to cygruby320.dll) > >>> > >>> I don't know if there's anything linked against this DLL (perhaps rub= y > >>> bindings provided by other packages) which will get broken? > >>> > >>> Please hold off on uploading this until I have a chance to look into > >>> that issue a bit more. > >> It seems we have a handful of ruby binding packages, which install a .= so > >> file into /usr/lib/ruby/vendor_ruby/2.6/ which is linked against > >> cygruby260.dll: > >> > >> ruby-gv > >> ruby-marisa > >> ruby-openbabel > >> ruby-openwsman > >> ruby-solv > >> ruby-xapian > >> ruby-zinnia > >> subversion-ruby > > ruby-caca also belongs on this list, but the ruby binding hasn't been > rebuilt since ruby 2.3.0 > > Additionally, there are some packages which install a .so into > /usr/lib/gems/ruby/2.6/, which probably need similar treatment? > > >> (There might also be some other packages which link with that dll to > >> embed the ruby interpreter or something, but those are harder for me t= o > >> identify quickly...) > >> > >> I think this can be handled in the same way as perl, i.e. add somethin= g > >> like "ruby_PROVIDES=3Druby_${${VERSION%.*}//./}" to ruby.cygport, and = add > >> a mechanism to cygport to make the binding packages have an additional > >> dependency on that provide. > >> > >> I'll look into retroactively adding this to the existing ruby 2.6.x > >> packages, to prevent non-working combinations of packages getting inst= alled. --0000000000007a96cf05f9eb9514 Content-Type: application/octet-stream; name="pkg_info.cygpart.diff" Content-Disposition: attachment; filename="pkg_info.cygpart.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lgrwgel10 ZGlmZiAtLWdpdCBhL2xpYi9wa2dfaW5mby5jeWdwYXJ0IGIvbGliL3BrZ19pbmZvLmN5Z3BhcnQK aW5kZXggYjkwMjJkNzMuLjM3Y2ZhNjc2IDEwMDY0NAotLS0gYS9saWIvcGtnX2luZm8uY3lncGFy dAorKysgYi9saWIvcGtnX2luZm8uY3lncGFydApAQCAtODEsNyArODEsNyBAQCBfX2xpc3RfZGVw cygpIHsKIAlsb2NhbCBtbGRlcCBtbGRpciBtbGxpYgogCWxvY2FsIHBocGRlcCBwaHBtb2RkaXIg cGxkZXAgcGxkaXJzIHBsdmVyCiAJbG9jYWwgcHlkZXAgcHlkaXJzIHB5ZXh0cyBweXNjciBweXNp dGUgcHl2ZXIKLQlsb2NhbCByYmRlcCByYmRpcnMgZ2VtZGlyIGdlbWV4dGRpciBnZW1zcGVjZGly CisJbG9jYWwgcmJkZXAgcmJkaXJzIHJidmVyIGdlbWRpciBnZW1leHRkaXIgZ2Vtc3BlY2Rpcgog CWxvY2FsIHRjbGRlcCB0Y2xwa2dzIHZhcGlkZXAgdmFwaWRpcgogCWxvY2FsIHRjZ2NjbGliZGly IHRjZ2Njc3lzcm9vdAogCWxvY2FsIGRsbHRvb2w9ImRsbHRvb2wiCkBAIC01OTksNiArNTk5LDE5 IEBAIGZvciBzdWZmaXgsIG1vZGUsIHR5cGUgaW4gaW1wLmdldF9zdWZmaXhlcygpOiBwcmludChz dWZmaXgpJykKIAkJZG9uZQogCWZpCiAKKwlyYnZlcj0oICQoZmluZCAiJHtALy9eX14vIH0iIC1w YXRoICJ1c3IvKi9ydWJ5L3ZlbmRvcl9ydWJ5L1swLTldLlswLTldLyoiIFwKKwkgICAgICAgIHwg c2VkIC1FICdzIXVzci8uKi9ydWJ5L3ZlbmRvcl9ydWJ5LyhbMC05XSkuKFswLTldKS8uKiFydWJ5 X1wxXDIhJyBcCisJICAgICAgICB8IHNvcnQgLXJ1KSApCisJaWYgWyAiJHsjcmJ2ZXJbQF19IiAt Z3QgMSBdCisJdGhlbgorCQl3YXJuaW5nICJNb3JlIHRoYW4gb25lIHRhcmdldGVkIFJ1YnkgdmVy c2lvbjogJHtyYnZlclsqXX0sIgorCQl3YXJuaW5nICJ1c2luZyBvbmx5IHRoZSBsYXRlc3QgYXMg ZGVwZW5kZW5jeTogJHtyYnZlclswXX0uIgorCWZpCisJaWYgWyAiJHsjcmJ2ZXJbQF19IiAtZ3Qg MCBdICYmIFsgIiR7UE59IiAhPSAicnVieSIgXQorCXRoZW4KKwkJZWNobyAiJHtyYnZlclswXX0i CisJZmkKKwogCWlmIFsgJChmaW5kICIke0AvL15fXi8gfSIgLXBhdGggJ3Vzci9zaGFyZS9kb2Mv KicgLXBydW5lIFwKIAkJJHtkZXBzX3BydW5lfSBcCiAJCS1vIC1wYXRoICd1c3Ivc2hhcmUvaGVs cC8qJyAtcHJ1bmUgXApAQCAtNjM3LDYgKzY1MCw3IEBAIGZvciBzdWZmaXgsIG1vZGUsIHR5cGUg aW4gaW1wLmdldF9zdWZmaXhlcygpOiBwcmludChzdWZmaXgpJykKIAlhbGxkZXBzKz0iICIkKGZp bmQgIiR7QC8vXl9eLyB9IiAtdHlwZSBsIHwgeGFyZ3MgLXIgcmVhZGxpbmsgLWYpCiAKIAkjIGFk ZCBwZXJsNV8weHkgcmVxdWlyZW1lbnQgaWYgbGlua2VkIHdpdGggY3lncGVybDVfeHkuZGxsCisJ IyBhZGQgcnVieV94eSByZXF1aXJlbWVudCBpZiBsaW5rZWQgd2l0aCBjeWdydWJ5eHkwLmRsbAog CWZvciBkbGwgaW4gJChlY2hvICR7YWxsZGVwc30gfCB0ciBcXG4gJyAnICkgOyBkbwogCSAgICBj YXNlICIke2RsbCMjKi99IiBpbgogCQljeWdwZXJsNV9bMC05XVswLTldLmRsbCkKQEAgLTY0NCw2 ICs2NTgsMTEgQEAgZm9yIHN1ZmZpeCwgbW9kZSwgdHlwZSBpbiBpbXAuZ2V0X3N1ZmZpeGVzKCk6 IHByaW50KHN1ZmZpeCknKQogCQkgICAgcGx2ZXI9IiR7cGx2ZXIlJS5kbGx9IgogCQkgICAgZWNo byAicGVybDVfMCR7cGx2ZXJ9IgogCQkgICAgOzsKKwkJY3lncnVieVswLTldWzAtOV0wLmRsbCkK KwkJICAgIHJidmVyPSIke2RsbCMjKmN5Z3J1Ynl9IgorCQkgICAgcmJ2ZXI9IiR7cmJ2ZXIlJTAu ZGxsfSIKKwkJICAgIGVjaG8gInJ1YnlfJHtyYnZlcn0iCisJCSAgICA7OwogCSAgICBlc2FjCiAJ ZG9uZQogCg== --0000000000007a96cf05f9eb9514--