From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id C1DC83857C4F for ; Fri, 24 May 2024 13:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1DC83857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1DC83857C4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716557753; cv=none; b=FVbufUxQtByfkfOCSrGdd74BK2ejsQMf5qAV8ngZt1i7YvlmFGIqg82DjthjH4QftYV7yebHPpeGKsb84DDRTLzi8e7sfHY8CahDnFdhMroxOxXyGGi9Cgn2q3LU63soSlIcZg9DSJNBAK32pPgh/HGF9sN061EW2lZVbAIeJ6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716557753; c=relaxed/simple; bh=8aLPhnmfP7VoOHijmbbZwwylHVCBthTfvNgLLJKrHKY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=IfidKZLw3GUoQ5KMW7Y//DDmzH4UfKXwtIkTK1POYPc2MAeLmj9DvRrvnsDpMCPkhCXb394EcC7BsjrE9kqmyQfLio1QFU8iTv2YocXSLfqHa0VDuJui+tn78tZbx0/TvXJk4I8k5uoG8r+tWjtHQ5fOCToTirImedZBkgGHFVo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-24c1234beb3so1321733fac.0 for ; Fri, 24 May 2024 06:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716557750; x=1717162550; darn=cygwin.com; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8aLPhnmfP7VoOHijmbbZwwylHVCBthTfvNgLLJKrHKY=; b=Z652PALRqCXfBkTCdJMtUrek39Awfj5oicGLF9b+V+72N0oIIPzBv3vWEdOZDvCtnp AnW3TtVho4Q12vG8hNKs0wvI2zt8XIJpAT5Yr7rTA3NknrEn+KzFLpnnzGZlTQL48ZGG KKYeE+VcFJlchgwDe48zABWaiSAYp8Te+8xTuhQGQuFymmHYaLZa71uNnxPQoaATzgNk L+fy3x0+ljY1wPQ5f+gRW+1p7EgKhAlqlAevY/BAh6UStwSWFc8XkgJoO4H+bBhigzzJ FSMgT/Rz46I1xV1zkikz7HSfveYYfcUBIaU39hrgiKNLEIDeTocSkNBNsfVZh8OtffIm ulyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716557750; x=1717162550; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8aLPhnmfP7VoOHijmbbZwwylHVCBthTfvNgLLJKrHKY=; b=LWgR3o2xcDhqp42qqkme68Dz3GU9dWABawUUIG0tR4/YVzb+HBrWks7RGUYXYkQXDM j+8I4K5za7G1XykkEKK/+ld/KOvRS88QG0AkM1hmWmgbOpqYDlwA5C+TTJ5ZYNQxY7yd 8abj3M6A0/VVpFqlgO0pZuI0BkeoEBMOJqF2c0OLTOAKmObrKzhoCT7WSo70CMZKqIdw XGuigoZmxPbem7+XB+0NdongmFIkO/Ci8PkhaT56MxHWjwVviq4PvemqN4udb82lICvK A4WWIE1/63Lg60CiBnU4oe7EOIf1LHa3xB5qha/Xts1Sca9GPWAaZvL5uG0L8lI/L21C j0bQ== X-Gm-Message-State: AOJu0YwKxXcOBA7Z5aZJHxv0xcZryvy13PPuJChqIgeUVhOJ6e/i8fhJ FBlrcLUhXu2My8xuar3TCceM8ZZHytjXVnPl7nsBwDn0/MgSQKchEBZVTwhVnfzwywXDdBJHZAw vJAvdU40DTLyF46LzRSKizTKOGAfS9g== X-Google-Smtp-Source: AGHT+IG0+xCdVt50gD9PDWbQmIJOhb+JPzbZrXojycHnDZryuNsdpWq+rfxdAgK6asdsbYD8IyFGynkiwZqrlmgZk/I= X-Received: by 2002:a05:6870:7182:b0:22a:628a:4fad with SMTP id 586e51a60fabf-24c9f4ff16dmr1086855fac.9.1716557750470; Fri, 24 May 2024 06:35:50 -0700 (PDT) MIME-Version: 1.0 References: <5e4c5b9f-4f11-4ab5-984e-108393b7acb4@dronecode.org.uk> In-Reply-To: <5e4c5b9f-4f11-4ab5-984e-108393b7acb4@dronecode.org.uk> From: Daisuke Fujimura Date: Fri, 24 May 2024 22:35:14 +0900 Message-ID: Subject: Re: [PATCH cygport] pkg_info.cygpart: Do not detect dependencies on itself in ruby package To: cygwin-apps@cygwin.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Using cygport-0.36.9-1 with this patch merged in, it was confirmed that a ruby-3.3.1 package could be created in the local development environment. Thank you for merging. On Mon, May 6, 2024 at 11:12=E2=80=AFPM Jon Turney wrote: > > On 03/04/2024 15:18, Daisuke Fujimura via Cygwin-apps wrote: > > Thank you for reviewing this. > > > >> Can you clarify what the "failure" is here? > > > [...] > > > > /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file > > -- rbconfig (LoadError) > > > [...] > > Thanks very much for the detailed explanation. > > So this is an error (or warning?) generated by invoking the > not-yet-properly installed, just-built ruby in ${D}. > > I applied your patch. > > > On Sun, Mar 10, 2024 at 10:34=E2=80=AFPM Jon Turney wrote: > >> > >> On 16/02/2024 12:51, Daisuke Fujimura via Cygwin-apps wrote: > >>> Attempting to create a package for ruby-3.3, but it fails when trying > >>> to detect a dependency on itself. > >> > >> Thanks for this patch. > >> > >> Can you clarify what the "failure" is here? > >> > >>> To avoid this, skip them if the target is `ruby`. > >> > >> The second hunk seems like a removes the dependency on ruby_xy for the > >> ruby package, which also provides ruby_xy. > >> > >> Historically, we've allowed self-dependencies like this, because they > >> seem to be benign, although it seems like we could do with some generi= c > >> code to suppress them > > ... except I added something to generically prevent a packages provides: > appearing it it's requires: >