From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id ACDA63858401 for ; Wed, 3 Apr 2024 14:18:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACDA63858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACDA63858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712153934; cv=none; b=vo4F7Nkdi9vYdQ52eDvAMRK4RKJaV+C/4jL28q+3uZiRXdNBluDJ6VD2QiEXeeHXEsTMv5rEfAP2HpLFTFvp35QAef5eGDWgjxr3XA8ik2UDASZLVjB02XVhnh3yQiDUDE0sPFQVu0UgL6EiieSJpLZUMMsCaPcjA1EOXPdSMRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712153934; c=relaxed/simple; bh=9y1Yl8ny2xjaZniyQOrAHpticH7/ET2lZ004XDH8I5E=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=gRTz53rWmXbV2MMn29ENfPq/rt02IcWEluUfZg6DbpD5wxt1mFR3HK3v9c7SJ7B9Kvn4hFV0YUZPSSgobVv1T6jR4FN69v5Q0XSOOD+Q0qKynzCna1Hv/1sajrWHWNF4nDsyiLXhT96y6u4xMzDSzNR8tvW/XdY4cLvHXlQaZ64= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-22e997d8daaso239493fac.3 for ; Wed, 03 Apr 2024 07:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712153932; x=1712758732; darn=cygwin.com; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9y1Yl8ny2xjaZniyQOrAHpticH7/ET2lZ004XDH8I5E=; b=ACtp3+qEVs45K4dzItKvK8qU5cnKGJuRgp7n/83Z7iSNYtpC1ZVxM3zMsyXo6c+kl/ rwD9tM0Fob1//TiivnTIxfSLaUceajrs2dR3qrnbcNwjH78BlL4wMGn8zy2RMwHVkEJL qPMz8llH2Sl1L01jq0jYU9n11b87ssnzpaa/Go4U5GGJ9N0+D2rrQ/NvXp4BvnwMLs5F qh3vHoX1XgVJ5alDUZ28hYYvZixLnZEuLh/Gs2DXxvo7W0AEsxmPVxMJXEY+tigLO6zM Ip6pOFgf2PT3/WX73L2MU46R/uVgjHc5prLGd+U/gDupNiLs/wIsSBHq+Vo1YU4bjnHz FJjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712153932; x=1712758732; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9y1Yl8ny2xjaZniyQOrAHpticH7/ET2lZ004XDH8I5E=; b=uLn/Qko0JXVR2oiw7zY0uTC6UwO4awc0gP9MFLrDGO2wzf/Fp1qukNl7EhBxk+hsHf E+eG9x1BH4CbWK0GOXG7q+av4x02yqSyeos4/2Pk84PKmpIa+kADr+QkgGn4RiRqiS1S bxRRgAg0QHMjsjaXE5jgZlqvc//svOr1INvevhzrdKL3BjFadt2YyXQene5lbEFYQV+K cQsHlH7ug2maAEYV8ymdPA7LTmSAfqaNVUXst63ZPR3rBSmfMeToRv6XhxxOMgfekq+n tF1GfoTCjSRRNcglfH0O/3/+aYPzFBQkiSShGV8r2QWfs75pn/5xKp67SAbMSXzlDYHl cGHw== X-Gm-Message-State: AOJu0Yy0Uwc+Wvw07xXSXvDJNBBe15CA0g69p4rWLUazh06DbPX2nbk7 E7jfV74lBH/e7YtzzyQR6rjFkv0iBvaFPOyJmsRiBbjU9P2vRJOnHqzrnWstEqymePZKfghdJ4y yw3/oM0wDOVS3sc2uqtzjL5Czac7djdD/ X-Google-Smtp-Source: AGHT+IEIRfulwpEEBZyHZYrla/qDeiM2tu8bM+sCFMJVnHGiCIXBxAjueYiOXjDVFPOKIA8tVXVIEW2dPnmHVwDnYto= X-Received: by 2002:a05:6871:20d:b0:220:c604:8df with SMTP id t13-20020a056871020d00b00220c60408dfmr3019425oad.37.1712153931812; Wed, 03 Apr 2024 07:18:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Daisuke Fujimura Date: Wed, 3 Apr 2024 23:18:15 +0900 Message-ID: Subject: Re: [PATCH cygport] pkg_info.cygpart: Do not detect dependencies on itself in ruby package To: cygwin-apps@cygwin.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you for reviewing this. > Can you clarify what the "failure" is here? ruby.cygport and its CI results are as follows. - https://cygwin.com/cgit/cygwin-packages/ruby/commit/?id=3D65af41c137b45d0= 9614ea99f78d7a4818b1bdfb1 - https://github.com/cygwin/scallywag/actions/runs/7580195232/job/206457445= 55#step:6:22939 ``` >>> Creating source package ruby-3.3.0-1.src/ ruby-3.3.0-1.src/2.0.0-cygwin-configure.patch ruby-3.3.0-1.src/2.0.0-cygwin-rubygems.patch ruby-3.3.0-1.src/2.5.1-win32-resolv.patch ruby-3.3.0-1.src/9357.patch ruby-3.3.0-1.src/ruby-2.1.0-always-use-i386.patch ruby-3.3.0-1.src/ruby-2.1.0-custom-rubygems-location.patch ruby-3.3.0-1.src/ruby-2.1.0-Enable-configuration-of-archlibdir.patch ruby-3.3.0-1.src/ruby-2.1.0-Prevent-duplicated-paths-when-empty-version-str= ing-i.patch ruby-3.3.0-1.src/ruby-2.3.0-ruby_version.patch ruby-3.3.0-1.src/ruby-3.3.0-Disable-syntax-suggest-test-case.patch ruby-3.3.0-1.src/ruby-3.3.0.tar.gz ruby-3.3.0-1.src/ruby-3.4.0-ruby-net-http-Renew-test-certificates.patch ruby-3.3.0-1.src/ruby.cygport /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' >>> ruby requires: cygwin libcrypt2 libffi8 libgcc1 libgmp10 libssl3 libyam= l0_2 ruby_33 zlib0 ca-certificates /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' >>> ruby-devel requires: pkg-config ruby ruby_33 libcrypt-devel libgmp-deve= l /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' /usr/share/rubygems/rubygems.rb:8:in `require': cannot load such file -- rbconfig (LoadError) from /usr/share/rubygems/rubygems.rb:8:in `' from :2:in `require' from :2:in `' >>> ruby-doc requires: >>> ruby-tcltk requires: ruby-tk >>> Testing ruby-3.3.0-1.x86_64 : : ``` LoadError is occurring three times because the ruby.exe used to detect dependencies in the ruby package is not /usr/bin/ruby.exe but ${D}/usr/bin/ruby.exe. - https://github.com/cygwin/cygport/blob/0.36.8/lib/pkg_info.cygpart#L562 - https://github.com/cygwin/cygport/blob/0.36.8/lib/pkg_info.cygpart#L564 - https://github.com/cygwin/cygport/blob/0.36.8/lib/pkg_info.cygpart#L565 ${D}/usr/bin/ruby.exe is used because ${D} is added to the PATH. - https://github.com/cygwin/cygport/blob/0.36.8/lib/pkg_info.cygpart#L137 As the ruby package itself does not depend on ruby-* other than its own sub-packages, we considered that lines 560~600 did not need to be executed. - https://github.com/cygwin/cygport/blob/0.36.8/lib/pkg_info.cygpart#L560-L= 600 As for `ruby_xy`, as pointed out, there should be no diff. On Sun, Mar 10, 2024 at 10:34=E2=80=AFPM Jon Turney wrote: > > On 16/02/2024 12:51, Daisuke Fujimura via Cygwin-apps wrote: > > Attempting to create a package for ruby-3.3, but it fails when trying > > to detect a dependency on itself. > > Thanks for this patch. > > Can you clarify what the "failure" is here? > > > To avoid this, skip them if the target is `ruby`. > > The second hunk seems like a removes the dependency on ruby_xy for the > ruby package, which also provides ruby_xy. > > Historically, we've allowed self-dependencies like this, because they > seem to be benign, although it seems like we could do with some generic > code to suppress them > > (e.g. cygport also ends up generating cygwin-debuginfo with a dependency > on itself, which is harmless but could be suppressed) >