From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id CAF623858426 for ; Fri, 6 Oct 2023 12:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAF623858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1dd71c0a41fso1273224fac.2 for ; Fri, 06 Oct 2023 05:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696596060; x=1697200860; darn=cygwin.com; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CUdyqB9pbgq9xiA7Q4qHENrNBdCLpuF+/tlFnczUNWU=; b=OJTfdfwrZ5CJSA7+4RQTK4v2RLGI6vRopAA77zSyr0o5YgL9Vensn9CZmi/IO5ktn/ gWvG5jBWoh937x+kRVrXC5V3N6bNeb9KR8+hOZuE8IitI1IUJnxRcLl5yFyXHBGvb3Mk Gaah0T7Fj2+Qo/OFiv+He+Za1HoYVzdU1LMVPQ0J2CSonTnJ/OaA0kK7jTXE/Iz6ZTIJ obLPNzrgQRheFlOvpRKla07JCFsG7RyRj2EBRmUhfzPYVDPXuKco93qNNdoWZwZ8OOmp F3NvSq2lsQIG/M5x4Iax+TUixPY4NxCxOQPVCB3Fo4Kpo2GAicURjhn8+AOYUh3wuqdr qBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696596060; x=1697200860; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CUdyqB9pbgq9xiA7Q4qHENrNBdCLpuF+/tlFnczUNWU=; b=Xzxi2ANi6CwL1nFZl3S5iV2N9LWPOmse9o8oSyqQDMBZ2f0EB5pN9dgIwUvi9tGcMs XkBoJWtEBguexCKzC6u+5Za+4IoV8QhS52GmS2K6iQpginQHdPV3Wkk5/YlcMdYSOMb0 KO65ojj/+DuIxL97JZXW6+p7J4gznR97g3cuGdKTDORXWzL4cn8Ijwb5xFi83CxBSSmR hh5/F/6hT04Uw3y5+TMD+ppGonEAlZn7aB/BRNg8IJuwTOC6cFOcNd/xMkx9bGpVKn1J KuxpzUVKqSy1WpyZj4MP6mWpgchDnt76FrT2HmUD+d9/HM9kNl9C9JOHDUSErt/zuJDl djvQ== X-Gm-Message-State: AOJu0Yy6kShU+tzKS8row8aqSq6MwOiisuGsHRwN9wQL90rS8D7vuJnT YDs+x7/9AFq405AqGi6QZpdaAU8cNt9tggnCr8ZSFL6nH2E= X-Google-Smtp-Source: AGHT+IGIX2QIZqjF0IKOMOyMT2VAX6t1ctyjnQGTWsTmPFjHSi0kc0cnTyUjBDd+sX1IxPZP3ORLgN/zIGSCbMxrg1c= X-Received: by 2002:a05:6870:6592:b0:1cc:e169:96bf with SMTP id fp18-20020a056870659200b001cce16996bfmr9091831oab.39.1696596060422; Fri, 06 Oct 2023 05:41:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Daisuke Fujimura Date: Fri, 6 Oct 2023 21:40:23 +0900 Message-ID: Subject: Re: [Attn Maintainer] json-c To: cygwin-apps@cygwin.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: src_test is not redefined in cmake.cygclass (and ninja.cygclass) in cygport-0.36.3. Therefore, I defined src_test in json-c.cygport. - https://github.com/cygwin/cygport/blob/0.36.6/cygclass/cmake.cygclass - https://github.com/cygwin/cygport/blob/0.36.6/cygclass/ninja.cygclass I agree that it would be preferable to have src_test defined in one of these cygclasses. On Sun, Oct 1, 2023 at 11:43=E2=80=AFPM Jon Turney wrote: > > On 24/09/2023 13:40, Daisuke Fujimura via Cygwin-apps wrote: > > Hi, > > > > I previously reported that json-c.pc seems incorrect. > > - https://cygwin.com/pipermail/cygwin/2023-August/254350.html > > > > The modified version of json-c.cygport and its CI results are shown bel= ow. > > - cygport > > - https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=3D42= b2343c88e9ba85dd689579335a77776691bb27 > > - CI > > - https://github.com/cygwin/scallywag/actions/runs/6286740463 > > > > Patch is also attached. > > Thanks. > > Since Marco isn't available at the moment, I did an NMU with this change. > > > - PATH=3D${B}:${PATH} ctest > > + PATH=3D${B}:${PATH} ninja_test > > Not sure if this part is needed. > > But it seems like it indicates a missing piece in cygport. Perhaps there > should be a src_test() defined by the cmake.cygclass which does > ninja_test or ctest depending on the generator? >